-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] KNN filtering with limit and KNN distance function #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuel-keller
changed the title
KNN filtering with limit
KNN filtering with limit and knn distance function
May 15, 2024
emmanuel-keller
changed the title
KNN filtering with limit and knn distance function
[Feat] KNN filtering with limit and May 22, 2024
knn
distance function
emmanuel-keller
changed the title
[Feat] KNN filtering with limit and
[Feat] KNN filtering with limit and KNN distance function
May 22, 2024
knn
distance function
emmanuel-keller
added
topic:surrealql
This is related to the SurrealQL query language
topic:indexing
This is related to indexing and full-text search
labels
May 22, 2024
phughk
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, really cool thanks!
mumoshu
approved these changes
May 24, 2024
phughk
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic:indexing
This is related to indexing and full-text search
topic:surrealql
This is related to the SurrealQL query language
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation?
KNN operations should be able to be filtered, as described in #4000.
What does this change do?
This PR modifies the behavior of the
KNN
search so that the search reaches the K goal by bypassing documents that do not match the query.It also introduces the
vector::distance::knn()
function, which returns the distance computed during the query (avoiding recomputation).Eg.:
What is your testing strategy?
Tests have been written (for MTree and HNSW).
Is this related to any issues?
Fixes #4000
Does this change need documentation?
If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.
Have you read the Contributing Guidelines?