test: Add strand_with_nul_should_panic #4071
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
-[x] from core/ run
cargo test sql::value::serde::ser::value::tests::strand_with_nul_should_panic -- --exact --nocapture
-[x] from core/ run
cargo test
-[X] from core/ run
cargo test --release sql::value::serde::ser::value::tests::strand_with_nul_should_panic -- --exact --nocapture
-[] from / run
cargo test --release
FAILING:What is the motivation?
A Strand should not have any nul, '\0', characters.
What does this change do?
This tests that a panic should happen if a string to be serialized contains a null ('\0') byte.
Testing from within
core/
:What is your testing strategy?
Add one or more
should_panic
tests so nul byte handling is more thoroughly tested.Is this related to any issues?
Issue "Bug: Strand does not check for nul bytes in release mode" #4076
depending on what is decided this may or may not close the issue.
Does this change need documentation?
Have you read the Contributing Guidelines?