Fix cancelling task leading to an error #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiemh
approved these changes
Jun 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Great to hear, was it easily reproducible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
Cancellation of task upon shutdown could lead to errors being reported.
These tasks can be cancelled without problem and so the error resulting from its cancellation should be ignored.
What does this change do?
Ignores cancellation errors.
What is your testing strategy?
This error happens quite infrequently as it seems the shutdown needs to happen while the task is actively doing work for it to return an error. We don't have a good way to consistently replicate the behaviour so I have opted to leave the change untested as the extra error being returned is a relatively minor issue.
Whoever with an informal test of running the reproduction code provided in the linked issue numerous times with this fix I was no longer able to get the same issue to appear.
Is this related to any issues?
Fixes #4140
Does this change need documentation?
Have you read the Contributing Guidelines?