Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve structured output #4217

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Improve structured output #4217

merged 8 commits into from
Jun 25, 2024

Conversation

tobiemh
Copy link
Member

@tobiemh tobiemh commented Jun 18, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What does this change do?

Cleans up some code used to generate structured statement definition responses.

What is your testing strategy?

GitHub Actions testing.

Is this related to any issues?

Closes #3931.

Does this change need documentation?

  • No documentation needed

Have you read the Contributing Guidelines?

@tobiemh tobiemh requested a review from a team as a code owner June 18, 2024 12:26
kearfy
kearfy previously approved these changes Jun 18, 2024
Copy link
Contributor

@emmanuel-keller emmanuel-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability LGTM!

@tobiemh tobiemh enabled auto-merge June 18, 2024 13:13
@tobiemh tobiemh mentioned this pull request Jun 18, 2024
2 tasks
@gguillemas gguillemas dismissed stale reviews from emmanuel-keller and kearfy via de6a400 June 18, 2024 14:45
@tobiemh tobiemh added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit af80c1c Jun 25, 2024
22 checks passed
@tobiemh tobiemh deleted the tobiemh/structured branch June 25, 2024 08:07
@rushmorem rushmorem added this to the v2.0.0-alpha.3 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants