#34: Make --ns and --db arguments optional in command-line REPL #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for them to be specified at a later time. Defaults to an empty string.
|
@sunero4 thanks so much for this and for being a contributor! Awesome work 👏! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation?
Making
--nsand--dbarguments optional for thesqlsubcomman, allowing them to be specified at a later time.What does this change do?
Makes
--nsand--dbarguments optional for thesqlsubcommand in the CLI.What is your testing strategy?
I've run the CLI with the
sqlcommand against the SurrealDB database serve (started usingcargo run -- start memory --bind 0.0.0.0:9000 --user root --pass root, and verified that the CLI is able to start and that I can specify both thedbandnsvariables. After doing so I am also able to insert data.Is this related to any issues?
It is related to issue #34.
Have you read the Contributing Guidelines?
[x] I have read the Contributing Guidelines