Could not rewrite default value for readOnly property fix #7013 (#7014)

surveyjs · Sep 25, 2023 · 2fada3d · 2fada3d
1 parent 78884bd
commit 2fada3d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/survey-element.ts b/src/survey-element.ts
@@ -492,7 +492,7 @@ export class SurveyElement<E = any> extends SurveyElementCore implements ISurvey
    * @see readOnly
    */
   public get isReadOnly(): boolean {
-    return false;
+    return this.readOnly;
   }
   /**
    * Makes the survey element read-only.
@@ -501,7 +501,7 @@ export class SurveyElement<E = any> extends SurveyElementCore implements ISurvey
    * @see isReadOnly
    */
   public get readOnly(): boolean {
-    return this.getPropertyValue("readOnly", false);
+    return this.getPropertyValue("readOnly");
   }
   public set readOnly(val: boolean) {
     if (this.readOnly == val) return;

diff --git a/tests/jsonobjecttests.ts b/tests/jsonobjecttests.ts
@@ -2606,6 +2606,15 @@ QUnit.test("Change question isRequired default value", function (assert) {
   Serializer.findProperty("question", "isRequired").defaultValue = false;
   assert.equal(new Question("q1").isRequired, false, "It is false again");
 });
+QUnit.test("Change question readOnly default value", function (assert) {
+  assert.equal(new Question("q1").readOnly, false, "It is false by defult");
+  Serializer.findProperty("question", "readOnly").defaultValue = true;
+  assert.equal(new Question("q1").readOnly, true, "It is true now");
+  assert.deepEqual(new Question("q1").toJSON(), { name: "q1" }, "no readOnly attribute in JSON, #1");
+  Serializer.findProperty("question", "readOnly").defaultValue = false;
+  assert.equal(new Question("q1").readOnly, false, "It is false again");
+  assert.deepEqual(new Question("q1").toJSON(), { name: "q1" }, "no readOnly attribute in JSON, #2");
+});
 QUnit.test("Load localizable @property", function (assert) {
   Serializer.addClass("new_declared_props", [{
     name: "str1",