#6844 Incorrect question gap in detail form (#6940)

Fixes #6844
surveyjs · Sep 12, 2023 · 3d1d912 · 3d1d912
1 parent a051f5c
commit 3d1d912
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/src/question_matrixdropdownbase.ts b/src/question_matrixdropdownbase.ts
@@ -2303,6 +2303,7 @@ export class QuestionMatrixDropdownModelBase extends QuestionMatrixBaseModel<Mat
     if (this.isDesignMode) return this.detailPanel;
     var panel = this.createNewDetailPanel();
     panel.readOnly = this.isReadOnly;
+    panel.setSurveyImpl(row);
     var json = this.detailPanel.toJSON();
     new JsonObject().toObject(json, panel);
     panel.renderWidth = "100%";

diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-detail-one-row.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-detail-one-row.png
diff --git a/visualRegressionTests/tests/defaultV2/matrix.ts b/visualRegressionTests/tests/defaultV2/matrix.ts
@@ -693,6 +693,33 @@ frameworks.forEach(framework => {
     });
   });
 
+  test("Matrix detail questions in one row", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1920, 1080);
+      await initSurvey(framework, {
+        elements: [
+          {
+            type: "matrixdynamic",
+            name: "matrix",
+            rowCount: 2,
+            detailPanelMode: "underRow",
+            columns: [{ name: "col1" }],
+            detailElements: [{ type: "text", name: "q1" }, { type: "text", name: "q2", startWithNewLine: false }],
+            minWidth: "800px",
+            maxWidth: "800px",
+            width: "800px"
+          },
+        ],
+      });
+      await t
+        .click(Selector("#show-detail").nth(0))
+        .click(Selector("body"), { offsetX: 5, offsetY: 5 });
+
+      const questionRoot = Selector(".sd-question");
+      await takeElementScreenshot("question-matrix-detail-one-row.png", questionRoot, t, comparer);
+    });
+  });
+
   test("Matrix many columns", async (t) => {
     await wrapVisualTest(t, async (t, comparer) => {
       await t.resizeWindow(800, 600);