Set isMobile inside panels when they are in dynamic panels (#7093)

Referenced to #5935
surveyjs · Oct 9, 2023 · 4dff2c6 · 4dff2c6
1 parent eaffc8a
commit 4dff2c6
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 4 deletions.
diff --git a/src/question_paneldynamic.ts b/src/question_paneldynamic.ts
@@ -745,10 +745,8 @@ export class QuestionPanelDynamicModel extends Question
   }
   public setIsMobile(val: boolean) {
     super.setIsMobile(val);
-    (this.panels || []).forEach(panel => panel.elements.forEach(element => {
-      if(element instanceof Question) {
-        (element as Question).isMobile = val;
-      }
+    (this.panels || []).forEach(panel => panel.getQuestions(true).forEach(question => {
+      question.setIsMobile(val);
     }));
   }
 

diff --git a/tests/surveytests.ts b/tests/surveytests.ts
@@ -15845,6 +15845,44 @@ QUnit.test("Check survey isMobile is set correctly on adding new question", func
   const question = survey.getQuestionByName("q2");
   assert.ok(question.isMobile);
 });
+QUnit.test("Check survey isMobile is set correctly on question in nested dynamic panels", function (assert) {
+  const survey = new SurveyModel({
+    "logoPosition": "right",
+    "pages": [
+      {
+        "name": "page1",
+        "elements": [
+          {
+            "type": "paneldynamic",
+            "name": "question1",
+            "templateElements": [
+              {
+                "type": "panel",
+                "name": "panel1",
+                "elements": [
+                  {
+                    "type": "text",
+                    "name": "question2"
+                  }
+                ]
+              }
+            ]
+          }
+        ]
+      }
+    ]
+  });
+  survey.css = defaultV2Css;
+  survey.data = {
+    "question1": [
+      {}
+    ]
+  };
+  assert.notOk(survey.isMobile);
+  survey.setIsMobile(true);
+  assert.ok(survey.isMobile);
+  assert.ok(survey.getQuestionByName("question1").panels[0].getQuestionByName("question2").isMobile);
+});
 QUnit.test("Set correct activePage on fromSurvey and update buttons visibility", function (assert) {
   const survey = new SurveyModel({
     "elements": [