try to fix title location test blinking (#6979)

* try to fix title location test blinking * moved f-test to v-test
surveyjs · Sep 22, 2023 · 6d5ce94 · 6d5ce94
1 parent 8077326
commit 6d5ce94
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 50 deletions.
diff --git a/testCafe/survey/questionsInOneLine.js b/testCafe/survey/questionsInOneLine.js
@@ -73,54 +73,4 @@ frameworks.forEach((framework) => {
     assert(await isCountRight());
   });
 
-  test("change title location", async (t) => {
-    const isInputAboveHeader = ClientFunction(() => {
-      const h5 = document.querySelector(
-        "div[data-name='city'] h5:first-of-type"
-      );
-      const input = document.querySelector("div[data-name='city'] input");
-      return h5.getBoundingClientRect().top > input.getBoundingClientRect().top;
-    });
-
-    const isHeaderAboveInput = ClientFunction(() => {
-      const h5 = document.querySelector(
-        "div[data-name='city'] h5:first-of-type"
-      );
-      const input = document.querySelector("div[data-name='city'] input");
-      return h5.getBoundingClientRect().top < input.getBoundingClientRect().top;
-    });
-
-    assert(await isInputAboveHeader());
-
-    await changeTitleLocation("top");
-
-    assert(await isHeaderAboveInput());
-  });
-
-  test("change title location left", async (t) => {
-    const isInputAboveHeader = ClientFunction(() => {
-      var h5 = document.querySelectorAll(
-        "div[data-name='city'] h5:first-of-type"
-      )[0];
-      var input = document.querySelector("div[data-name='city'] input");
-      return (
-        h5.getBoundingClientRect().left === input.getBoundingClientRect().left
-      );
-    });
-
-    const isHeaderToTheLeftOfInput = ClientFunction(() => {
-      var h5 = document.querySelectorAll(
-          "div[data-name='city'] h5:first-of-type"
-        )[0],
-        input = document.querySelector("div[data-name='city'] input");
-      return (
-        h5.getBoundingClientRect().left < input.getBoundingClientRect().left
-      );
-    });
-
-    assert(await isInputAboveHeader());
-    await changeTitleLocation("left");
-
-    assert(await isHeaderToTheLeftOfInput());
-  });
 });
diff --git a/visualRegressionTests/tests/defaultV2/etalons/multiple-row-title-bottom.png b/visualRegressionTests/tests/defaultV2/etalons/multiple-row-title-bottom.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/multiple-row-title-left.png b/visualRegressionTests/tests/defaultV2/etalons/multiple-row-title-left.png
diff --git a/visualRegressionTests/tests/defaultV2/question.ts b/visualRegressionTests/tests/defaultV2/question.ts
@@ -235,6 +235,43 @@ frameworks.forEach(framework => {
     });
   });
 
+  test("Check questions in one row", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+
+      await t.resizeWindow(1920, 1080);
+      await initSurvey(framework, {
+        questions: [
+          {
+            type: "text",
+            name: "question_with_num",
+            title: "Personal information"
+          },
+          {
+            type: "text",
+            name: "question_with_num",
+            startWithNewLine: false,
+            title: "Contact information"
+          },
+        ]
+      },);
+      const rowSelector = Selector(".sd-row");
+      await resetFocusToBody();
+      await takeElementScreenshot("multiple-row.png", rowSelector, t, comparer);
+
+      await ClientFunction(() => {
+        window["survey"].questionTitleLocation = "bottom";
+        window["survey"].render();
+      })();
+      await takeElementScreenshot("multiple-row-title-bottom.png", rowSelector, t, comparer);
+
+      await ClientFunction(() => {
+        window["survey"].questionTitleLocation = "left";
+        window["survey"].render();
+      })();
+      await takeElementScreenshot("multiple-row-title-left.png", rowSelector, t, comparer);
+    });
+  });
+
   test("Check questions in one row with different default heights", async (t) => {
     await wrapVisualTest(t, async (t, comparer) => {