Clear incorrect empty values in checkbox, #3062 (#3067)

surveyjs · Jul 8, 2021 · 936bc3a · 936bc3a
1 parent 162254d
commit 936bc3a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/question_baseselect.ts b/src/question_baseselect.ts
@@ -410,9 +410,10 @@ export class QuestionSelectBase extends Question {
   protected hasUnknownValue(
     val: any,
     includeOther: boolean = false,
-    isFilteredChoices: boolean = true
+    isFilteredChoices: boolean = true,
+    checkEmptyValue: boolean = false
   ): boolean {
-    if (this.isValueEmpty(val)) return false;
+    if (!checkEmptyValue && this.isValueEmpty(val)) return false;
     if (includeOther && val == this.otherItem.value) return false;
     if (this.hasNone && val == this.noneItem.value) return false;
     var choices = isFilteredChoices
@@ -1081,7 +1082,7 @@ export class QuestionSelectBase extends Question {
   }
   protected canClearValueAnUnknow(val: any): boolean {
     if (!this.getStoreOthersAsComment() && this.isOtherSelected) return false;
-    return this.hasUnknownValue(val, true);
+    return this.hasUnknownValue(val, true, true, true);
   }
   protected clearDisabledValuesCore() {
     if (this.isValueDisabled(this.value)) {

diff --git a/tests/surveyquestiontests.ts b/tests/surveyquestiontests.ts
@@ -2316,6 +2316,9 @@ QUnit.test("question.clearIncorrectValues", function(assert) {
     [],
     "clear values, there is no these items in choices"
   );
+  qcheck.value = ["", 0, undefined, null];
+  qcheck.clearIncorrectValues();
+  assert.deepEqual(qcheck.value, [], "clear values, clear empty values");
 });
 
 QUnit.test("question.clearIncorrectValues and choicesByUrl", function(assert) {