Skip to content

Commit

Permalink
Add url property type and set it for imageLink, logo and backgroundImage
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewtelnov committed Oct 6, 2023
1 parent eb3742f commit ab726a6
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/cover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Serializer.addClass(
{ name: "textAreaWidth:number", minValue: 0, default: 512 },
{ name: "textGlowEnabled:boolean" },
{ name: "overlapEnabled:boolean" },
{ name: "backgroundImage" },
{ name: "backgroundImage:url" },
{ name: "backgroundImageOpacity:number", minValue: 0, maxValue: 1, default: 1 },
{ name: "backgroundImageFit", default: "cover", choices: ["cover", "fill", "contain"] },
{ name: "logoPositionX", default: "right" },
Expand Down
2 changes: 1 addition & 1 deletion src/question_image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ function getCorrectImageLink(val: string): string {
Serializer.addClass(
"image",
[
{ name: "imageLink", serializationProperty: "locImageLink" },
{ name: "imageLink:url", serializationProperty: "locImageLink" },
{ name: "altText", serializationProperty: "locAltText", alternativeName: "text", category: "general" },
{
name: "contentMode",
Expand Down
2 changes: 1 addition & 1 deletion src/question_imagepicker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ export class QuestionImagePickerModel extends QuestionCheckboxBase {
}
Serializer.addClass(
"imageitemvalue",
[{ name: "imageLink", serializationProperty: "locImageLink" }],
[{ name: "imageLink:url", serializationProperty: "locImageLink" }],
(value: any) => new ImageItemValue(value),
"itemvalue"
);
Expand Down
2 changes: 1 addition & 1 deletion src/question_signaturepad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ Serializer.addClass(
default: true,
},
{
name: "backgroundImage",
name: "backgroundImage:url",
category: "general",
},
{
Expand Down
4 changes: 2 additions & 2 deletions src/survey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7433,7 +7433,7 @@ Serializer.addClass("survey", [
serializationProperty: "locDescription",
dependsOn: "locale",
},
{ name: "logo", serializationProperty: "locLogo" },
{ name: "logo:url", serializationProperty: "locLogo" },
{ name: "logoWidth", default: "300px", minValue: 0 },
{ name: "logoHeight", default: "200px", minValue: 0 },
{
Expand Down Expand Up @@ -7649,7 +7649,7 @@ Serializer.addClass("survey", [
{ name: "width", visibleIf: (obj: any) => { return obj.widthMode === "static"; } },
{ name: "fitToContainer:boolean", default: false },
{ name: "headerView", default: "basic", choices: ["basic", "advanced"], visible: false },
{ name: "backgroundImage", visible: false },
{ name: "backgroundImage:url", visible: false },
{ name: "backgroundImageFit", default: "cover", choices: ["auto", "contain", "cover"], visible: false },
{ name: "backgroundImageAttachment", default: "scroll", choices: ["scroll", "fixed"], visible: false },
{ name: "backgroundOpacity:number", minValue: 0, maxValue: 1, default: 1, visible: false },
Expand Down

0 comments on commit ab726a6

Please sign in to comment.