work for #6205 fix RangeError: Maximum call stack size exceeded

surveyjs · Jul 20, 2023 · b12ffff · b12ffff
1 parent a82d92d
commit b12ffff
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/packages/survey-angular-ui/src/base-angular.ts b/packages/survey-angular-ui/src/base-angular.ts
@@ -89,15 +89,15 @@ export abstract class BaseAngular<T extends Base = Base> extends EmbeddedViewCon
     this.beforeUpdate();
     if(this.getPropertiesToUpdateSync().indexOf(key) > -1) {
       this.detectChanges();
-      this.afterUpdate();
+      this.afterUpdate(key);
     } else {
       ((<any>window)["__zone_symbol__queueMicrotask"]
         ? (<any>window)["__zone_symbol__queueMicrotask"] : queueMicrotask)(() => {
         if(!this.isDestroyed) {
           this.setIsRendering(true);
           this.detectChanges();
         }
-        this.afterUpdate();
+        this.afterUpdate(key);
       });
     }
   }
@@ -121,7 +121,7 @@ export abstract class BaseAngular<T extends Base = Base> extends EmbeddedViewCon
     }
     this.setIsRendering(true);
   }
-  protected afterUpdate(): void {
+  protected afterUpdate(key: string): void {
     if(this.getShouldReattachChangeDetector()) {
       this.getChangeDetectorRef().reattach();
     }

diff --git a/packages/survey-angular-ui/src/components/popup/popup-container.component.ts b/packages/survey-angular-ui/src/components/popup/popup-container.component.ts
@@ -45,13 +45,16 @@ export class PopupBaseContainerComponent<T extends PopupBaseViewModel = PopupBas
     this.changeDetectorRef.detectChanges();
   }
 
-  protected override afterUpdate(): void {
-    super.afterUpdate();
-    if (!this.prevIsVisible && this.model.isVisible) {
-      this.model.updateOnShowing();
-    }
-    if (this.prevIsVisible !== this.model.isVisible) {
-      this.prevIsVisible = this.model.isVisible;
+  protected override afterUpdate(key: string): void {
+    super.afterUpdate(key);
+
+    if(key === "isVisible") {
+      if (!this.prevIsVisible && this.model.isVisible) {
+        this.model.updateOnShowing();
+      }
+      if (this.prevIsVisible !== this.model.isVisible) {
+        this.prevIsVisible = this.model.isVisible;
+      }
     }
   }
   public clickInside(event: any) {