React: survey.onValueChanging do not allow to change value into Upper…

…Case fix #6519 (#6520)

packages/survey-angular-ui/src/components/dropdown/dropdown.component.ts

@@ -46,7 +46,7 @@ export class DropdownComponent extends BaseAngular implements OnInit {
       if (!!this.inputElementRef?.nativeElement) {
         const control: any = this.inputElementRef.nativeElement;
         const newValue = this.model.inputStringRendered;
-        if (!Helpers.isTwoValueEquals(newValue, control.value)) {
+        if (!Helpers.isTwoValueEquals(newValue, control.value, false, true)) {
           control.value = this.model.inputStringRendered || "";
         }
       }

src/calculatedValue.ts

@@ -145,7 +145,7 @@ export class CalculatedValue extends Base {
     if (!!this.expressionRunner) return;
     this.expressionRunner = new ExpressionRunner(this.expression);
     this.expressionRunner.onRunComplete = newValue => {
-      if (!Helpers.isTwoValueEquals(newValue, this.value)) {
+      if (!Helpers.isTwoValueEquals(newValue, this.value, false, true)) {
         this.setValue(newValue);
       }
       this.unlocCalculation();

src/question.ts

@@ -1592,7 +1592,7 @@ export class Question extends SurveyElement<Question>
       this.defaultValueRunner,
       this.getUnbindValue(this.defaultValue),
       (val) => {
-        if(!Helpers.isTwoValueEquals(this.value, val)) {
+        if(!this.isTwoValueEquals(this.value, val)) {
           this.value = val;
         }
       }
@@ -1627,7 +1627,7 @@ export class Question extends SurveyElement<Question>
     if (!setFunc) {
       setFunc = (val: any): void => {
         this.runExpressionSetValue(val, (val: any): void => {
-          if(!Helpers.isTwoValueEquals(this.value, val)) {
+          if(!this.isTwoValueEquals(this.value, val)) {
             this.value = val;
           }
         });

src/question_paneldynamic.ts

@@ -152,7 +152,7 @@ export class QuestionPanelDynamicItem implements ISurveyData, ISurveyImpl {
   public setValue(name: string, newValue: any) {
     const oldItemData = this.data.getPanelItemData(this);
     const oldValue = !!oldItemData ? oldItemData[name] : undefined;
-    if (Helpers.isTwoValueEquals(newValue, oldValue)) return;
+    if (Helpers.isTwoValueEquals(newValue, oldValue, false, true)) return;
     this.data.setPanelItemData(this, name, Helpers.getUnbindValue(newValue));
     const questions = this.panel.questions;
     for (var i = 0; i < questions.length; i++) {

src/question_text.ts

@@ -401,7 +401,7 @@ export class QuestionTextModel extends QuestionTextBase {
   private _isWaitingForEnter = false;
   private updateValueOnEvent(event: any) {
     const newValue = event.target.value;
-    if (!Helpers.isTwoValueEquals(this.value, newValue)) {
+    if (!this.isTwoValueEquals(this.value, newValue)) {
       this.value = newValue;
     }
   }

src/react/dropdown-base.tsx

@@ -193,7 +193,7 @@ export class SurveyQuestionDropdownBase<T extends Question> extends SurveyQuesti
     if (!!this.inputElement) {
       const control: any = this.inputElement;
       const newValue = this.question.dropdownListModel.inputStringRendered;
-      if (!Helpers.isTwoValueEquals(newValue, control.value)) {
+      if (!Helpers.isTwoValueEquals(newValue, control.value, false, true)) {
         control.value = this.question.dropdownListModel.inputStringRendered;
       }
     }

src/react/reactquestion_element.tsx

@@ -282,7 +282,7 @@ export class SurveyQuestionUncontrolledElement<
   }
   updateValueOnEvent = (event: any) => {
     if (
-      !Helpers.isTwoValueEquals(this.questionBase.value, event.target.value)
+      !Helpers.isTwoValueEquals(this.questionBase.value, event.target.value, false, true)
     ) {
       this.setValueCore(event.target.value);
     }
@@ -297,7 +297,7 @@ export class SurveyQuestionUncontrolledElement<
     if (!!this.control) {
       const control: any = this.control;
       const newValue = this.getValueCore();
-      if (!Helpers.isTwoValueEquals(newValue, control.value)) {
+      if (!Helpers.isTwoValueEquals(newValue, control.value, false, true)) {
         control.value = this.getValue(newValue);
       }
     }

src/react/reactquestion_matrix.tsx

@@ -157,7 +157,6 @@ export class SurveyQuestionMatrixRow extends ReactSurveyElement {
       var column = this.question.visibleColumns[i];
       var key = "value" + i;
 
-      //var isChecked = Helpers.isTwoValueEquals(row.value, column.value);
       var isChecked = row.value == column.value;
       let itemClass = this.question.getItemClass(row, column);
       var inputId = this.question.inputId + "_" + row.name + "_" + i;

src/react/tagbox-filter.tsx

@@ -29,7 +29,7 @@ export class TagboxFilterString extends SurveyElementBase<ITagboxFilterProps, an
     if (!!this.inputElement) {
       const control: any = this.inputElement;
       const newValue = this.model.inputStringRendered;
-      if (!Helpers.isTwoValueEquals(newValue, control.value)) {
+      if (!Helpers.isTwoValueEquals(newValue, control.value, false, true)) {
         control.value = this.model.inputStringRendered;
       }
     }

tests/surveytests.ts

@@ -17264,4 +17264,13 @@ QUnit.test("Check onPopupVisibleChanged events", function (assert) {
   popup.toggleVisibility();
   assert.equal(log, "->true->false");
 });
-
+QUnit.test("Check onPopupVisibleChanged events", function (assert) {
+  assert.equal(settings.comparator.caseSensitive, false, "comparator.caseSensitive is false");
+  const survey = new SurveyModel({ elements: [{ "type": "text", "name": "q1" }] });
+  const q = survey.getQuestionByName("q1");
+  survey.onValueChanging.add((sender, options) => {
+    options.value = options.value.toUpperCase();
+  });
+  q.value = "abc";
+  assert.equal(q.value, "ABC", "Convert to upper case");
+});