PR: Ranking question with only one choice does not show choice (#6648)

* fixed #6622 * fix func test
surveyjs · Aug 4, 2023 · c07b873 · c07b873
1 parent 184a697
commit c07b873
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/question_ranking.ts b/src/question_ranking.ts
@@ -143,6 +143,7 @@ export class QuestionRankingModel extends QuestionCheckboxModel {
     // ranking question with only one choice doesn't make sense
     if (this.visibleChoices.length === 1) {
       this.value = [];
+      this.value.push(this.visibleChoices[0].value);
       this.updateRankingChoices();
       return;
     }
@@ -221,10 +222,10 @@ export class QuestionRankingModel extends QuestionCheckboxModel {
     const newRankingChoices: ItemValue[] = [];
 
     // ranking question with only one choice doesn't make sense
-    if (this.visibleChoices.length === 1) {
-      this.setPropertyValue("rankingChoices", newRankingChoices);
-      return;
-    }
+    // if (this.visibleChoices.length === 1) {
+    //   this.setPropertyValue("rankingChoices", newRankingChoices);
+    //   return;
+    // }
 
     if (forceUpdate) this.setPropertyValue("rankingChoices", []);
 

diff --git a/testCafe/questions/ranking.js b/testCafe/questions/ranking.js
@@ -189,7 +189,7 @@ frameworks.forEach((framework) => {
       .click(checkboxToyotaItem);
 
     let data = await getData();
-    await t.expect(typeof data.bestcar).eql("undefined");
+    await t.expect(typeof data.bestcar).ok();
 
     await t.hover(rankAudiItem);
     await t.dragToElement(rankAudiItem, rankMercedesBenzItem);

diff --git a/tests/question_ranking_tests.ts b/tests/question_ranking_tests.ts
@@ -133,7 +133,7 @@ QUnit.test("Ranking: Carry Forward", function(assert) {
 
   // ranking question with only one choice doesn't make sense
   q1.value = ["2"];
-  assert.deepEqual(q2.isEmpty(), true);
+  assert.deepEqual(q2.isEmpty(), false);
   assert.deepEqual(survey.data, {
     q1: [2],
   });