survey.onValueChanged is not fired on changing question comment if va…

…lueName property is used fixed #8137 (#8138)
surveyjs · Apr 18, 2024 · c328a21 · c328a21
1 parent aabd758
commit c328a21
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 6 deletions.
diff --git a/src/survey.ts b/src/survey.ts
@@ -6594,11 +6594,7 @@ export class SurveyModel extends SurveyElementCore
    * @param locNotification For internal use.
    * @see getComment
    */
-  public setComment(
-    name: string,
-    newValue: string,
-    locNotification: any = false
-  ) {
+  public setComment(name: string, newValue: string, locNotification: any = false):void {
     if (!newValue) newValue = "";
     if (this.isTwoValueEquals(newValue, this.getComment(name))) return;
     var commentName = name + this.commentSuffix;
@@ -6620,7 +6616,7 @@ export class SurveyModel extends SurveyElementCore
     if (locNotification !== "text") {
       this.tryGoNextPageAutomatic(name);
     }
-    var question = this.getQuestionByName(name);
+    var question = this.getQuestionByValueName(name);
     if (question) {
       this.onValueChanged.fire(this, {
         name: commentName,

diff --git a/tests/question_baseselecttests.ts b/tests/question_baseselecttests.ts
@@ -1873,4 +1873,43 @@ QUnit.test("radiogroup with incorrect defaultValue, other & survey.data Bug#7943
   assert.deepEqual(survey.data, { q1: "other", "q1-Comment": "101" }, "survey.data");
   survey.doComplete(false);
   assert.deepEqual(survey.data, { q1: "other", "q1-Comment": "101" }, "survey.data on complete");
+});
+QUnit.test("On value changed, comment and valueName Bug#8137", (assert) => {
+  const survey = new SurveyModel({
+    "elements": [
+      {
+        "type": "radiogroup",
+        "name": "q1",
+        "valueName": "val1",
+        "choices": [1, 2],
+        "showOtherItem": true,
+      }
+    ]
+  });
+  let counter = 0;
+  let questionName = "";
+  let name = "";
+  let value = undefined;
+  survey.onValueChanged.add((sender, options) => {
+    counter ++;
+    questionName = options.question.name;
+    name = options.name;
+    value = options.value;
+  });
+  const q = <QuestionRadiogroupModel>survey.getQuestionByName("q1");
+  q.value = 1;
+  assert.equal(counter, 1, "counter #1");
+  assert.equal(questionName, "q1", "question.name #1");
+  assert.equal(name, "val1", "name #1");
+  assert.equal(value, 1, "value #1");
+  q.value = "other";
+  assert.equal(counter, 2, "counter #2");
+  questionName = "";
+  name = "";
+  value = undefined;
+  q.comment = "comment1";
+  assert.equal(counter, 3, "counter #3");
+  assert.equal(questionName, "q1", "question name #3");
+  assert.equal(name, "val1-Comment", "name #3");
+  assert.equal(value, "comment1", "value #3");
 });