Work for surveyjs/survey-creator#4484 - memory leaks in survey creato…

…r - dispose computed updaters

src/base.ts

@@ -141,6 +141,7 @@ export class Dependencies {
     this.dependencies.forEach(dependency => {
       dependency.obj.unregisterPropertyChangedHandlers([dependency.prop], dependency.id);
     });
+    // this.currentDependency = undefined;
   }
 }
 
@@ -191,6 +192,7 @@ export class Base {
     if (Base.currentDependencis === undefined) return;
     Base.currentDependencis.addDependency(target, property);
   }
+  public dependencies: {[key: string]: ComputedUpdater } = {};
   public static get commentSuffix(): string {
     return settings.commentSuffix;
   }
@@ -307,6 +309,7 @@ export class Base {
     }
     this.onPropertyValueChangedCallback = undefined;
     this.isDisposedValue = true;
+    Object.values(this.dependencies).forEach(dependencies => dependencies.dispose());
   }
   public get isDisposed() {
     return this.isDisposedValue === true;

src/jsonobject.ts

@@ -43,14 +43,19 @@ function getLocStringValue(
   return "";
 }
 
-export function property(options?: IPropertyDecoratorOptions) {
-  return function (target: any, key: string) {
+export function property(options: IPropertyDecoratorOptions = {}) {
+  // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+  return function (target: any, key: string): void {
     let processComputedUpdater = (obj: any, val: any) => {
       if (!!val && typeof val === "object" && val.type === ComputedUpdater.ComputedUpdaterType) {
         Base.startCollectDependencies(() => obj[key] = val.updater(), obj, key);
         const result = val.updater();
         const dependencies = Base.finishCollectDependencies();
         val.setDependencies(dependencies);
+        if(obj.dependencies[key]) {
+          obj.dependencies[key].dispose();
+        }
+        obj.dependencies[key] = val;
         return result;
       }
       return val;