Update the Completed Before page #7189

surveyjs · Nov 3, 2023 · d149d9b · d149d9b
1 parent e9b0dbc
commit d149d9b
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 6 deletions.
diff --git a/src/defaultV2-theme/blocks/sd-completedpage.scss b/src/defaultV2-theme/blocks/sd-completedpage.scss
@@ -2,6 +2,7 @@
 
 .sd-completedpage,
 .sd-completed-before-page {
+  align-items: center;
   font-family: $font-family;
   font-weight: bold;
   box-sizing: border-box;

diff --git a/src/defaultV2-theme/mixins.scss b/src/defaultV2-theme/mixins.scss
@@ -144,6 +144,13 @@
     user-select: none;
     outline: solid calcSize(0.25) transparent;
 
+    color: $primary;
+    font-weight: 600;
+    font-style: normal;
+    font-family: $font-family;
+    font-size: $font-questiontitle-size;
+    line-height: multiply(1.5, $font-questiontitle-size);
+
     &:hover {
       background-color: $background-dark;
     }
@@ -157,12 +164,12 @@
       align-items: center;
       flex-grow: 1;
       justify-content: center;
-      color: $primary;
-      font-weight: 600;
-      font-style: normal;
-      font-family: $font-family;
-      font-size: $font-questiontitle-size;
-      line-height: multiply(1.5, $font-questiontitle-size);
+      // color: $primary;
+      // font-weight: 600;
+      // font-style: normal;
+      // font-family: $font-family;
+      // font-size: $font-questiontitle-size;
+      // line-height: multiply(1.5, $font-questiontitle-size);
     }
   }
 }
diff --git a/visualRegressionTests/tests/defaultV2/etalons/survey-completed-before.png b/visualRegressionTests/tests/defaultV2/etalons/survey-completed-before.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/survey-completed.png b/visualRegressionTests/tests/defaultV2/etalons/survey-completed.png
diff --git a/visualRegressionTests/tests/defaultV2/survey.ts b/visualRegressionTests/tests/defaultV2/survey.ts
@@ -926,6 +926,38 @@ frameworks.forEach(framework => {
       await t.resizeWindow(1920, 1080);
     });
   });
+
+  test("Survey complete pages", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1600, 900);
+      const json = {
+        "cookieName": "survey-id",
+        "completedHtml": "<h3>Completed</h3><button>OK</button>",
+        "completedBeforeHtml": "<h3>Already completed</h3><button>OK</button>",
+        pages: [
+          {
+            "elements": [
+              {
+                "type": "text",
+                "name": "name",
+                "title": "Name"
+              }
+            ]
+          }
+        ]
+      };
+      await initSurvey(framework, json);
+      await t.click(".sd-navigation__complete-btn");
+      await takeElementScreenshot("survey-completed.png", Selector(".sd-root-modern"), t, comparer);
+      await ClientFunction(() => {
+        document.body.style.setProperty("--sjs-corner-radius", "0px");
+        (<any>window).survey.clear();
+        (<any>window).survey.isCompletedBefore = true;
+      })();
+      await takeElementScreenshot("survey-completed-before.png", Selector(".sd-root-modern"), t, comparer);
+    });
+  });
+
   test("Check survey in compact mode", async (t) => {
     await wrapVisualTest(t, async (t, comparer) => {
       await t.resizeWindow(1920, 1080);