Small refactor + add unit test

surveyjs · Oct 30, 2023 · e3d5814 · e3d5814
1 parent a83bf28
commit e3d5814
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/utils/camera.ts b/src/utils/camera.ts
@@ -116,14 +116,19 @@ export class Camera {
         callback(undefined);
       });
   }
+  public getImageSize(videoEl:HTMLVideoElement): { width: number, height: number } {
+    return { width: videoEl.videoWidth, height: videoEl.videoHeight };
+
+  }
   public snap(videoElementId: string, callback: BlobCallback): boolean {
     if("undefined" === typeof document) return false;
     const root = document;
     const videoEl: HTMLVideoElement = root.getElementById(videoElementId) as HTMLVideoElement;
     if(!videoEl) return false;
     const canvasEl = root.createElement("canvas");
-    canvasEl.height = videoEl.videoHeight;
-    canvasEl.width = videoEl.videoWidth;
+    const imageSize = this.getImageSize(videoEl);
+    canvasEl.height = imageSize.height;
+    canvasEl.width = imageSize.width;
     let context = canvasEl.getContext("2d");
     /*
     if(this._facingMode == 'user'){

diff --git a/tests/questionFileTests.ts b/tests/questionFileTests.ts
@@ -1577,6 +1577,12 @@ QUnit.test("new Camera().getMediaConstraints width and height", function(assert)
   assert.deepEqual(mConst.video.height, { ideal: 100 });
   Camera.clear();
 });
+QUnit.test("Camera: check getImageSize method", function(assert) {
+  let imageSize = new Camera().getImageSize({ videoWidth: 100, videoHeight: 200 } as any);
+  assert.deepEqual(imageSize, { width: 100, height: 200 });
+  imageSize = new Camera().getImageSize({ videoWidth: 130, videoHeight: 250 } as any);
+  assert.deepEqual(imageSize, { width: 130, height: 250 });
+});
 QUnit.test("QuestionFile stop playing video on hiding question", function(assert) {
   let survey = new SurveyModel({
     elements: [{ type: "file", name: "q1" }]