! operator with async expressions causes error fix #7268 (#7272)

* ! operator with async expressions causes error fix #7268 * Typo in unit test #7268
surveyjs · Nov 1, 2023 · f384178 · f384178
1 parent 4c97513
commit f384178
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/expressions/expressions.ts b/src/expressions/expressions.ts
@@ -166,11 +166,19 @@ export class UnaryOperand extends Operand {
     const uOp = <UnaryOperand>op;
     return uOp.operator == this.operator && this.areOperatorsEquals(this.expression, uOp.expression);
   }
+  public hasFunction(): boolean {
+    return this.expression.hasFunction();
+  }
+  public hasAsyncFunction(): boolean {
+    return this.expression.hasAsyncFunction();
+  }
+  public addToAsyncList(list: Array<FunctionOperand>): void {
+    this.expression.addToAsyncList(list);
+  }
   public evaluate(processValue?: ProcessValue): boolean {
     let value = this.expression.evaluate(processValue);
     return this.consumer.call(this, value);
   }
-
   public setVariables(variables: Array<string>) {
     this.expression.setVariables(variables);
   }

diff --git a/tests/surveytests.ts b/tests/surveytests.ts
@@ -13748,6 +13748,34 @@ QUnit.test(
     SurveyElement.FocusElement = oldFunc;
   }
 );
+QUnit.test("Async function with negative result, Bug#7268",
+  function (assert) {
+    let returnResult: (res: any) => void = (res: any): void => {
+      res = false;
+    };
+    function asyncFunc(params: any): any {
+      returnResult = this.returnResult;
+      return false;
+    }
+    FunctionFactory.Instance.register("asyncFunc", asyncFunc, true);
+    const survey = new SurveyModel({
+      elements: [
+        { type: "text", name: "q1", isRequired: true },
+        {
+          type: "text", name: "q2", visibleIf: "!asyncFunc({q1})"
+        }
+      ],
+    });
+    const q1 = survey.getQuestionByName("q1");
+    const q2 = survey.getQuestionByName("q2");
+    returnResult(true);
+    assert.equal(q2.isVisible, false, "visible #1");
+    q1.value = 1;
+    returnResult(false);
+    assert.equal(q2.isVisible, true, "visible #2");
+    FunctionFactory.Instance.unregister("asyncFunc");
+  }
+);
 
 QUnit.test(
   "Focus errored question when checkErrorsMode: `onComplete` + onServerValidateQuestions, Bug#2466",