Incorrect clear properties in choicesByUrl fix #6766 (#7070)

surveyjs · Oct 5, 2023 · f6af288 · f6af288
1 parent 1241c00
commit f6af288
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/src/choicesRestful.ts b/src/choicesRestful.ts
@@ -439,12 +439,12 @@ export class ChoicesRestful extends Base {
     if (prop.type == "itemvalue[]") return "itemvalue";
     return prop.type;
   }
-  public clear() {
-    this.url = "";
-    this.path = "";
-    this.valueName = "";
-    this.titleName = "";
-    this.imageLinkName = "";
+  public clear(): void {
+    this.url = undefined;
+    this.path = undefined;
+    this.valueName = undefined;
+    this.titleName = undefined;
+    this.imageLinkName = undefined;
     var properties = this.getCustomPropertiesNames();
     for (var i = 0; i < properties.length; i++) {
       if ((<any>this)[properties[i]]) (<any>this)[properties[i]] = "";

diff --git a/tests/surveyserializationtests.ts b/tests/surveyserializationtests.ts
@@ -323,6 +323,25 @@ QUnit.test("Deserialize choicesByUrl", function (assert) {
     "data is copied correctly"
   );
 });
+QUnit.test("Change choicesByUrl.path default value", function (assert) {
+  const prop = Serializer.findProperty("choicesByUrl", "path");
+  assert.ok(prop, "Property is here");
+  prop.defaultValue = "list";
+  let question = new QuestionDropdownModel("q1");
+  assert.equal(question.choicesByUrl.path, "list", "Get value from property default value");
+  const survey = new SurveyModel({
+    elements: [
+      {
+        type: "dropdown",
+        name: "question1",
+        choicesByUrl: {
+          valueName: "name"
+        }
+      }] });
+  question = <QuestionDropdownModel>survey.getQuestionByName("question1");
+  assert.equal(question.choicesByUrl.path, "list", "Get value from property default value, #2");
+  prop.defaultValue = undefined;
+});
 QUnit.test("MatrixDropdown serialize and deserialize", function (assert) {
   var matrix = new QuestionMatrixDropdownModelBase("q1");
   matrix.columns.push(new MatrixDropdownColumn("col1"));