Name rows correctly in getPlainData for matrix dynamic (#7375)

surveyjs · Nov 17, 2023 · fe0ae50 · fe0ae50
1 parent cb923d8
commit fe0ae50
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/src/question_matrixdropdownbase.ts b/src/question_matrixdropdownbase.ts
@@ -241,6 +241,9 @@ implements ISurveyData, ISurveyImpl, ILocalizableOwner {
   public get rowName(): any {
     return null;
   }
+  public get dataName(): string {
+    return this.rowName;
+  }
   public get text(): any {
     return this.rowName;
   }
@@ -1767,7 +1770,7 @@ export class QuestionMatrixDropdownModelBase extends QuestionMatrixBaseModel<Mat
       questionPlainData.data = this.visibleRows.map(
         (row: MatrixDropdownRowModelBase) => {
           var rowDataItem = <any>{
-            name: row.rowName,
+            name: row.dataName,
             title: row.text,
             value: row.value,
             displayValue: this.getRowDisplayValue(false, row, row.value),

diff --git a/src/question_matrixdynamic.ts b/src/question_matrixdynamic.ts
@@ -31,6 +31,12 @@ export class MatrixDynamicRowModel extends MatrixDropdownRowModelBase implements
   public get rowName() {
     return this.id;
   }
+  public get dataName(): string {
+    return "row" + (this.index + 1);
+  }
+  public get text(): any {
+    return "row " + (this.index + 1);
+  }
   public getAccessbilityText(): string {
     return (this.index + 1).toString();
   }

diff --git a/tests/question_matrixdynamictests.ts b/tests/question_matrixdynamictests.ts
@@ -8954,3 +8954,23 @@ QUnit.test("matrixdynamic.removeRow & confirmActionAsync, #6736", function (asse
 
   settings.confirmActionAsync = prevAsync;
 });
+QUnit.test("matrix dynamic getPlainData", function (assert) {
+  const survey = new SurveyModel({
+    elements: [
+      { type: "matrixdynamic", name: "matrix",
+        columns: [{ cellType: "text", name: "col1" }, { cellType: "text", name: "col2" }]
+      }
+    ]
+  });
+  const q = <QuestionMatrixDynamicModel>survey.getQuestionByName("matrix");
+  q.value = [{ col1: 1, col2: 2 }, { col1: 3, col2: 4 }];
+  const data: any = survey.getPlainData();//["matrix"];
+  const row1Name = data[0].data[0].name;
+  const row1Title = data[0].data[0].title;
+  const row2Name = data[0].data[1].name;
+  const row2Title = data[0].data[1].title;
+  assert.equal(row1Name, "row1", "row1 name");
+  assert.equal(row1Title, "row 1", "row1 title");
+  assert.equal(row2Name, "row2", "row2 name");
+  assert.equal(row2Title, "row 2", "row2 title");
+});