Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goNextPageAutomatic not working #252

Closed
ericdmessick opened this issue Feb 21, 2017 · 11 comments
Closed

goNextPageAutomatic not working #252

ericdmessick opened this issue Feb 21, 2017 · 11 comments
Assignees
Labels

Comments

@ericdmessick
Copy link

ericdmessick commented Feb 21, 2017

Using React version code produced from the dxsurvey service. No bootstrap. This is what I am getting when I run page locally.

I'm doing a range of 1-10. If the user choses any rating less than 5, a new question appears. 5 and over should just complete the page. However, if I click anything over 5+, I get this error:

Uncaught RangeError: Maximum call stack size exceeded

WIth one exception. If I click 10, the question that should only appear for less than 5 appears.

The code I am entering in visibleIf is pretty straight forward.

{question} < 5

Here are the links to the survey. To get to the page in question, answer question in this order:

  1. Nope...
  2. Yes.
  3. I hate you.
  4. [THE PAGE IN QUESTION]

https://surveyfordummies.herokuapp.com/

@ericdmessick
Copy link
Author

So, I removed the ranking '10'. It only goes up to nine. I don't know why '10' would be cause the conditional to trigger if it was set <5.

However, the error:

Uncaught RangeError: Maximum call stack size exceeded

...still throws if you choose 5-9 and the survey will not complete.

@andrewtelnov
Copy link
Member

@ericdmessick You are using the 0.11.1 version. The bug has been fixed in v0.12.0: #238. Please get the latest version: v0.12.1

Thank you,
Andrew

@ericdmessick
Copy link
Author

I updated to the new version 0.12.1, but it still does the same thing.

@andrewtelnov
Copy link
Member

andrewtelnov commented Feb 22, 2017

@ericdmessick Sorry, it is definitely another issue. I have created a plunker example. Could you please fork it, then change it, so it doesn't work and post a new link here.
Because, I do not understand how to reproduce the problem.

Thank you,
Andrew

@ericdmessick
Copy link
Author

ericdmessick commented Feb 23, 2017 via email

@dmitry-kurmanov
Copy link
Member

dmitry-kurmanov commented Feb 23, 2017

@ericdmessick, Hello! Thank you for the report. I've seen error in the console at your site. I've tried find problem, but you are using min(uglify) version. Could you get version of your site with "dev" bundle that I could debug it, please. Or create fiddle with this error as Andrew said.

PS we are working on functional testing, so we hope that same problems will go away

@ericdmessick
Copy link
Author

@dmitrykurmanov I did the plunker fork as requested by @andrewtelnov. Here is a link to the github as well. https://github.com/ericdmessick/SurveyForDummies.git for now.

@andrewtelnov
Copy link
Member

@ericdmessick Unfortunately, you did not share a plunker fork link with us. We do not have an access to it :-(
We can take a look on your repo of course.

Thank you,
Andrew

@dmitry-kurmanov dmitry-kurmanov self-assigned this Feb 27, 2017
@dmitry-kurmanov
Copy link
Member

dmitry-kurmanov commented Feb 27, 2017

2b71c8680f

I've just copy @ericdmessick 's JSON into our editor and here is the bug. So it is not only react version bug.

And I've removed "goNextPageAutomatic" property and it is ok now. So it is "goNextPageAutomatic" bug

@dmitry-kurmanov dmitry-kurmanov changed the title Rating buttons not working goNextPageAutomatic not working Feb 27, 2017
@dmitry-kurmanov
Copy link
Member

@ericdmessick, we'll fix it. Thanks for your help!

@andrewtelnov
Copy link
Member

@ericdmessick There was an call stack overflow if properties goNextPageAutomatic and clearInvisibleValues are set to true.
I have fixed it.

Thank you,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants