Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to null object error in matrix-rubric in preview page because of "paneldynamic" #2602

Closed
PPTA22 opened this issue Jan 8, 2021 · 10 comments
Assignees
Labels

Comments

@PPTA22
Copy link

PPTA22 commented Jan 8, 2021

What is the current behavior?

incorrect showing matrix-rubric in preview page because of using "paneldynamic"
just showing a big black circle in the middle of the page

What is the expected behavior?

correctly show the matrix-rubric in the preview page,

How would you reproduce the current behavior (if this is a bug)?

plz find the html file in the attachment(zip file)
test.zip

Specify your

  • browser: firefox 84.0.1 / edge(chromium)
  • surveyjs version: latest
@andrewtelnov
Copy link
Member

@PPTA22 Could you please point to the issue? Here is your example on plunker.

Thank you,
Andrew

@PPTA22
Copy link
Author

PPTA22 commented Jan 8, 2021

sorry for the late reply, please also add the preview setting survey.showPreviewBeforeComplete = 'showAnsweredQuestions'; ,
then you would see that the survey preview page is not showing properly
image
image

@andrewtelnov
Copy link
Member

@PPTA22 I can't reproduce the issue in my example. Could you please fork my example and modify it so it doesn't work or modify your example and make it works.

Thank you,
Andrew

@PPTA22
Copy link
Author

PPTA22 commented Jan 8, 2021

@andrewtelnov
Copy link
Member

@PPTA22 It works fine on my side. I have tried it in Chrome, FireFox and IE. Did you apply your changes in this plunker?

Thank you,
Andrew

@PPTA22
Copy link
Author

PPTA22 commented Jan 8, 2021

In my firefox, Edge both have this issue, the only thing i added on your plunker is
survey.showPreviewBeforeComplete = 'showAnsweredQuestions';

this problem not only happened in one computer, i was using my office computer, then now I am using my own computer,
both of them have this issue
image

image

@andrewtelnov
Copy link
Member

@PPTA22 I did not click on "Preview" button. Got it now.

Thank you,
Andrew

@andrewtelnov andrewtelnov self-assigned this Jan 8, 2021
@PPTA22
Copy link
Author

PPTA22 commented Jan 8, 2021

Thank you 👍

@andrewtelnov andrewtelnov changed the title [bug] incorrect showing matrix-rubric in preview page because of "paneldynamic" Incorrect showing matrix-rubric in preview page because of "paneldynamic" Jan 8, 2021
@andrewtelnov andrewtelnov changed the title Incorrect showing matrix-rubric in preview page because of "paneldynamic" Reference to null object error in matrix-rubric in preview page because of "paneldynamic" Jan 8, 2021
andrewtelnov added a commit that referenced this issue Jan 8, 2021
@andrewtelnov
Copy link
Member

@PPTA22 The bug is fixed by the commit above. We will include the fix in v1.8.24.

Thank you,
Andrew

@PPTA22
Copy link
Author

PPTA22 commented Jan 9, 2021

Thank you so much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants