Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale doesn't update for editText #6523

Closed
Sandarr95 opened this issue Jul 13, 2023 · 1 comment
Closed

Locale doesn't update for editText #6523

Sandarr95 opened this issue Jul 13, 2023 · 1 comment
Assignees
Labels
bug user issue An issue or bug reported by users
Milestone

Comments

@Sandarr95
Copy link

Are you requesting a feature, reporting a bug or asking a question?

Bug report

What is the current behavior?

editText does not update locale on locale change while being rendered.

What is the expected behavior?

editText should update locale on locale change while being rendered.
In the image above this should have resulted in the text "Bewerk" being shown, not "Edit".

How would you reproduce the current behavior (if this is a bug)?

{
 "pages": [
  {
   "name": "page1",
   "elements": [
    {
     "type": "text",
     "name": "question1"
    }
   ]
  }
 ],
 "previewText": {
  "nl": "Voorbeeld",
  "en": "Preview"
 },
 "showPreviewBeforeComplete": "showAnsweredQuestions"
}
  • Click on the preview tab
  • Answer question1 with something
  • Click on Preview
  • Change the language to Dutch

Now the send button changes languages as expected, the edit text does not.

Specify your

  • browser: Firefox
  • browser version: 115
  • surveyjs platform (angular or react or jquery or knockout or vue): react
  • surveyjs version: 1.9.79 (locally, I don't know which version runs on surveyjs.io)
@andrewtelnov andrewtelnov self-assigned this Jul 13, 2023
@andrewtelnov andrewtelnov added bug user issue An issue or bug reported by users labels Jul 13, 2023
@andrewtelnov andrewtelnov added this to the v1.9.98 milestone Jul 13, 2023
@andrewtelnov
Copy link
Member

@Sandarr95 It is fixed by the commit above.

Thank you,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user issue An issue or bug reported by users
Projects
None yet
Development

No branches or pull requests

2 participants