Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispose question/panel/page on calling delete() #6676

Closed
andrewtelnov opened this issue Aug 8, 2023 · 0 comments
Closed

dispose question/panel/page on calling delete() #6676

andrewtelnov opened this issue Aug 8, 2023 · 0 comments
Assignees
@andrewtelnov
Labels
bug user issue An issue or bug reported by users
Milestone
v1.9.102

Comments

@andrewtelnov
Copy link
Member

We have to call model.dispose() inside model.delete().
Otherwise it leads to issues like this.
@andrewtelnov andrewtelnov added bug user issue An issue or bug reported by users labels Aug 8, 2023
@andrewtelnov andrewtelnov self-assigned this Aug 8, 2023
andrewtelnov added a commit that referenced this issue Aug 8, 2023
@andrewtelnov
dispose question/panel/page on calling delete() fix #6676
9a3cc29
@tsv2013 tsv2013 closed this as completed in 9c7c933 Aug 8, 2023
@andrewtelnov andrewtelnov added this to the v1.9.102 milestone Aug 8, 2023
@andrewtelnov andrewtelnov mentioned this issue Aug 8, 2023
Closed
novikov82 added a commit that referenced this issue Apr 3, 2024
@novikov82
#6676 - fixed selection in readonly and preview mode
f134285
novikov82 added a commit that referenced this issue Apr 16, 2024
@dmitry-kurmanov @novikov82
PR: Read-only and Preview Mode: Redesign: Root Issue (#7999)
4512328 
* work for the #6776

* work for the #6776

* work for the #6776

* work for the #6776

* #6776 - implemented preview for rating stars and skipped tests for disabled

* #6776 - dropdown, tagbox

* #6776 - fixed u-tests

* #6776 - comment and fix singleinput test

* #6776 - multipletext

* #6776 - fixed u-tests

* #6776 - fixed some v-tests

* work for the #6776 (checkbox group)

* work for the #6776 (checkbox group)

* #6776 - fix rating small stars

* #6776 - try to fix responsivity test

* work for the #6776 (ranking spike)

* work for the surveyjs/service#1464 (ranking)

* #6776 - try to fix angular test

* #6776 - fix rating in matrix test

* #6776 - remove DIM color

* #6776 - fixed build

* #6776 - skip matrix preview test for angular

* #6776 - revert angular test skip

* work for the #6776 (boolean, boolean:radio, boolean:checkbox)

* work for the #6776 (boolean markup)

* work for the #6776 (imagepicker)

* #6776 - matrix single-choice

* #6776 - support disabled in old themes

* work for the #6776 (file)

* work for the #6776 (test.only)

* work for the #6776 (review)

* #6676 - fixed selection in readonly and preview mode

* work for the #6776

* #6776 - colored rating

* #6776 - fixed markup tests

* #6779 - matrix alt-rows

* #6776

* #6776 - fixed v-tests

* work for the #6776

* #6776 - siganture, dynamic panel

* #6776 - signature and panel

* work for the #6776

* work for the #6776

* #6776 - update screenshot

* Update readonly-preview.ts

* work for the #6776

* #6776 - update preview etalons for dynamic panel

* #6776 - vixed matrix altrow backcolor

* work for the #6776

* #6776 - fixed radio checkbox color

* #6776 - update screenshots

* #6776 - fixed dynamic panel rendering

* work for the #6776

* work for the #6776

* #6776 - add dot to "no signature"

* #6776 - fix matrix input color for altrow

* #6776 - fix angular dynamic panels

* #6776 - fixed boolean radio rendering

* work for the #6776

* work for the #6776

* #6776 - fix markup tests

* #6776 - fixed boolean paddings

* #6776 - update boolean screenshots

* work for the #6776

* work for the #6776

* #6776 - simplify code

---------

Co-authored-by: Aleksey Novikov <novikov82@gmail.com>
Co-authored-by: Aleksey Novikov <novikov@abrisplatform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
bug user issue An issue or bug reported by users
Projects
None yet
Milestone
v1.9.102
Development

No branches or pull requests
1 participant
@andrewtelnov