Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goNextPageAutomatic property should not work for checkbox/matrix #70

Closed
andrewtelnov opened this issue Sep 15, 2016 · 6 comments
Closed
Labels

Comments

@andrewtelnov
Copy link
Member

andrewtelnov commented Sep 15, 2016

If goNextPageAutomatic property set to true, on answering all questions, the survey goes on the next page.
It should not work for checkbox and matrix questions. Currently, on setting on check, the survey goes on the next page which is wrong.

@andrewtelnov andrewtelnov changed the title goNextPageOnQuestionsComplete property should not work for checkbox/matrix goNextPageAutomatic property should not work for checkbox/matrix Sep 16, 2016
@andrewtelnov
Copy link
Member Author

4 questions support this property only: radio, dropdown, rating and text.
For more information take a look at unit test: "goNextPageAutomatic: should not work for complex questions like matrix, checkbox, multiple text".

@elsigh
Copy link
Contributor

elsigh commented Feb 1, 2018

I've found a bug where if you set the valueName property on a checkbox type item and goNextPageAutomatic: true it automatically jumps to the next page upon the first click of a checkbox. I'm guessing it's some part related to the code that looks like this.tryGoNextPageAutomatic(name);

@elsigh
Copy link
Contributor

elsigh commented Feb 1, 2018

^ Actually, I don't know why I was using valueName vs just name and title in my test fwiw. When using name+title all works as expected so this may be a non-issue

@andrewtelnov
Copy link
Member Author

@elsigh It sounds as a bug to me. It is a valid scenario. We will look at it.

Thank you,
Andrew

@andrewtelnov
Copy link
Member Author

@elsigh I have reproduced the bug in a unit test and fix it. The fix will be available in the next release.

Thank you,
Andrew

@elsigh
Copy link
Contributor

elsigh commented Feb 2, 2018

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants