Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add new functionality into question.isReady property #7001

Closed
andrewtelnov opened this issue Sep 23, 2023 · 0 comments
Closed

Refactor and add new functionality into question.isReady property #7001

andrewtelnov opened this issue Sep 23, 2023 · 0 comments
Assignees
@andrewtelnov
Labels
bug enhancement
Milestone
v1.9.110

Comments

@andrewtelnov
Copy link
Member

We need to return false for question.isReady when:

  • Questions with the same valueName are not ready
  • async functions in any expressions are not executed
  • source carry forward question is not Ready

The functionality should be refactored first
@andrewtelnov andrewtelnov self-assigned this Sep 23, 2023
andrewtelnov added a commit that referenced this issue Sep 23, 2023
@andrewtelnov
Implement the base refactoring #7001
ddf00b2
andrewtelnov added a commit that referenced this issue Sep 23, 2023
@andrewtelnov
Support valueName (related questions) in isReady #7001
2ff12ce
andrewtelnov added a commit that referenced this issue Sep 23, 2023
@andrewtelnov
Include async function in expression execution into isReady #7001
252ca50
andrewtelnov added a commit that referenced this issue Sep 23, 2023
@andrewtelnov
Support isReady for carry-foward, #7001
b1ffb00
andrewtelnov added a commit that referenced this issue Sep 23, 2023
@andrewtelnov
FIx the issue with carry-forward & choicesfromurl & predefined values #…
9ca2539 
…7001
This was referenced Sep 24, 2023
Closed
Closed
novikov82 pushed a commit that referenced this issue Sep 25, 2023
@andrewtelnov
Features/7001 question isready (#7002)
0782d1d 
* Implement the base refactoring #7001

* Support valueName (related questions) in isReady #7001

* Include async function in expression execution into isReady #7001

* Support isReady for carry-foward, #7001

* FIx the issue with carry-forward & choicesfromurl & predefined values #7001
@OlgaLarina OlgaLarina added this to the v1.9.110 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
bug enhancement
Projects
None yet
Milestone
v1.9.110
Development

No branches or pull requests
2 participants
@andrewtelnov @OlgaLarina