Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: HTML Question - new A11Y structure #7027

Merged
merged 2 commits into from
Sep 27, 2023
Merged

PR: HTML Question - new A11Y structure #7027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
886c235
work for the https://github.com/surveyjs/survey-library/issues/7024
dmitry-kurmanov Sep 27, 2023
d36c071
Merge branch 'master' into bug/7024-a11y-html-question
dmitry-kurmanov Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/question_html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ export class QuestionHtmlModel extends QuestionNonValue {
private processHtml(html: string): string {
return this.survey ? this.survey.processHtml(html, "html-question") : this.html;
}
public get isNewA11yStructure(): boolean {
return true;
}
}
Serializer.addClass(
"html",
Expand Down
4 changes: 2 additions & 2 deletions tests/markup/snapshots/page-swnl-v2.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<div style="flex:1 1 50%; max-width:100%; min-width:300px;">
<div aria-invalid="false" aria-required="false" class="sd-question sd-question--html sd-row__question" data-name="question0" id="testid0" role="textbox">
<div class="sd-question sd-question--html sd-row__question" data-name="question0" id="testid0">
<div class="sd-question__content" role="presentation">
<div class="sd-html">HTML1</div>
</div>
</div>
</div>
<div style="flex:1 1 50%; max-width:100%; min-width:300px;">
<div aria-invalid="false" aria-required="false" class="sd-question sd-question--html sd-row__question" data-name="question1" id="testid1" role="textbox">
<div class="sd-question sd-question--html sd-row__question" data-name="question1" id="testid1">
<div class="sd-question__content" role="presentation">
<div class="sd-html">HTML2</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions tests/markup/snapshots/panel-page-swnl-v2.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div style="flex:1 1 50%; max-width:100%; min-width:300px;">
<div aria-invalid="false" aria-required="false" class="sd-question sd-question--html sd-row__question" data-name="question0" id="testid0" role="textbox">
<div class="sd-question sd-question--html sd-row__question" data-name="question0" id="testid0">
<div class="sd-question__content" role="presentation">
<div class="sd-html">HTML1</div>
</div>
Expand All @@ -10,7 +10,7 @@
<div class="sd-panel__content" id="testidp0_content">
<div class="sd-clearfix sd-row">
<div style="flex:1 1 100%; max-width:100%; min-width:300px;">
<div aria-invalid="false" aria-required="false" class="sd-element--nested sd-question sd-question--html sd-row__question" data-name="question1" id="testid1" role="textbox">
<div class="sd-element--nested sd-question sd-question--html sd-row__question" data-name="question1" id="testid1">
<div class="sd-question__content" role="presentation">
<div class="sd-html">HTML2</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions tests/markup/snapshots/panel-swnl-v2.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="sd-clearfix sd-row">
<div style="flex: 1 1 100%; max-width: 100%; min-width: 300px;">
<div aria-invalid="false" aria-required="false" class="sd-element--nested sd-question sd-question--html sd-row__question" data-name="question1" id="testid1" role="textbox">
<div style="flex:1 1 100%; max-width:100%; min-width:300px;">
<div class="sd-element--nested sd-question sd-question--html sd-row__question" data-name="question1" id="testid1">
<div class="sd-question__content" role="presentation">
<div class="sd-html">HTML2</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions tests/markup/snapshots/panel.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="sv_row">
<div style="flex: 1 1 100%; max-width: 100%; min-width: 300px;">
<div aria-invalid="false" aria-required="false" class="sv_q sv_qstn" data-name="question1" id="testid0" role="textbox">
<div style="flex:1 1 100%; max-width:100%; min-width:300px;">
<div class="sv_q sv_qstn" data-name="question1" id="testid0">
<div role="presentation">
<div>HTML content here</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions tests/markup/snapshots/survey-navigation.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<div class="sv_body sv_body--static sv-components-column sv-components-column--expandable" id="testidpage0">
<div class="sv_p_root">
<div class="sv_row">
<div style="flex: 1 1 100%; max-width: 100%; min-width: 300px;">
<div aria-invalid="false" aria-required="false" class="sv_q sv_qstn" data-name="q1" id="testid0" role="textbox">
<div style="flex:1 1 100%; max-width:100%; min-width:300px;">
<div class="sv_q sv_qstn" data-name="q1" id="testid0">
<div role="presentation">
<div>
<div>
Expand Down