Remove unneeded calc in scc #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsv2013
reviewed
Oct 2, 2023
tsv2013
reviewed
Oct 2, 2023
tsv2013
reviewed
Oct 2, 2023
tsv2013
reviewed
Oct 2, 2023
|
Previously $font-size was a fallback to --font-size variable. Probably we break something. |
tsv2013
reviewed
Oct 3, 2023
| margin: 0; | ||
| color: $cover-title-forecolor; | ||
| font-family: $font-surveytitle-family; | ||
| font-size: $font-surveytitle-size; | ||
| font-size: var(--default-font-size); |
There was a problem hiding this comment.
May be it would be better to introduce a global css variable --sjs-font--default-surveytitle-size to use here and in st-title.scss
tsv2013
reviewed
Oct 3, 2023
| font-family: $font-pagetitle-family; | ||
| font-weight: $font-pagetitle-weight; | ||
| font-size: $font-pagetitle-size; | ||
| font-size: var(--default-font-size); |
There was a problem hiding this comment.
Probably better to use different variable names for different objects. It's hard to find what variable to set or rename if they have the same names.
tsv2013
reviewed
Oct 3, 2023
| @@ -29,11 +29,12 @@ | |||
| flex-grow: 1; | |||
|
|
|||
| .sd-title { | |||
| --default-font-size: var(--sjs-font-surveytitle-size, calc(2 * (var(--sjs-font-size, 16px)))); | |||
There was a problem hiding this comment.
May be it would be better to introduce a global css variable --sjs-font--default-surveytitle-size
…m/surveyjs/survey-library into features/scss-optimize-generation
tsv2013
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.