Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I 6.5 - Tracking Note editing State] - Error on click to finish editing #439

Closed
JESii opened this issue May 20, 2017 · 4 comments
Closed

Comments

@JESii
Copy link

JESii commented May 20, 2017

At the end of this section, you say "If you click a Note twice to confirm the edit, you should see an Uncaught Invariant Violation error..."

Instead, when I click the Note once, I get this error:
image

Commit with the code is here

@bebraw
Copy link
Member

bebraw commented May 20, 2017

Yeah, looks like the error changed in React 15. Good point.

@JESii
Copy link
Author

JESii commented May 20, 2017

At some point, I think you're gonna have to pick a release and just stick with it -- else you could go nuts trying to keep up with this.

With webpack and package.json, couldn't you just 'freeze' things in a known state and have a reliable target?

@bebraw
Copy link
Member

bebraw commented May 20, 2017

A big rewrite is needed anyhow so it's good you open these issues. 👍

@JESii
Copy link
Author

JESii commented May 20, 2017

OK; I'll call 'em as I sees 'em :=)

@JESii JESii closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants