Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 06_react_and_flux.md #9

Merged
merged 1 commit into from
May 5, 2015
Merged

Update 06_react_and_flux.md #9

merged 1 commit into from
May 5, 2015

Conversation

afilp
Copy link
Contributor

@afilp afilp commented May 5, 2015

I am not sure if I get it right (most likely not), but shouldn't this be "coupled"?

I am not sure if I get it right (most likely not), but shouldn't this be "coupled"?
bebraw added a commit that referenced this pull request May 5, 2015
Update 06_react_and_flux.md
@bebraw bebraw merged commit e03e112 into survivejs:master May 5, 2015
@bebraw
Copy link
Member

bebraw commented May 5, 2015

Good catch! Thanks for the fix.

Btw I went through the material at a session today and noticed a bunch of smaller issues to fix.

@afilp
Copy link
Contributor Author

afilp commented May 5, 2015

You are doing a great work, by the way. As I am new here, should I "Delete Branch" now or this is not necessary?

@afilp
Copy link
Contributor Author

afilp commented May 5, 2015

I know this is completely irrelevant: I am using your code (from this example 06) for trying to learn and I added the "React Dev Tools for Chrome" to debug, etc.

However, the "Top Level" continuously refreshes inside React Tools. So I cannot do anything debug-wise! It appears as if it is created and re-created continuously. Do you have any idea what the case may be? Thanks!

@bebraw
Copy link
Member

bebraw commented May 5, 2015

You are doing a great work, by the way. As I am new here, should I "Delete Branch" now or this is not necessary?

You can delete the branch if you want. It won't make much difference from my perspective.

In case you have other fixes in mind, you can sync your master and then create a branch per patch:

git branch feature-name
git checkout feature-name
... do changes
git push
... create PR at GitHub

It might be faster to open issues here as you notice things. I'll be able to fix them quite fast that way.

I opened a separate issue (#10) for your React Dev Tools problem. I have a rough idea what might be causing it but we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants