-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added merge multiple that outputs an array #74
Conversation
assert.deepEqual(merge(a, b), result); | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra test case to add. a
with client
and b
with server
alone. This should yield output with both configurations.
Test also partials like a
: client
, server
+ b
: server
, test
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay those tests have been added. I think they conform to what you were saying
Give me a little bit, ES lint has flagged all the line endings, so need to fix those up. Will update shortly. |
Document this at the README. Good to go after that. Great work. 👍 |
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 95.28% 95.45% +0.16%
==========================================
Files 4 4
Lines 191 198 +7
Branches 62 62
==========================================
+ Hits 182 189 +7
Misses 9 9
Continue to review full report at Codecov.
|
I've documented this in the readme, let me know if something else needs adding to it. |
Published. Amazing work. Thanks. 👍 |
You're most welcome |
No description provided.