Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added merge multiple that outputs an array #74

Merged
merged 4 commits into from
Mar 16, 2017

Conversation

herecydev
Copy link
Contributor

No description provided.

assert.deepEqual(merge(a, b), result);
});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra test case to add. a with client and b with server alone. This should yield output with both configurations.

Test also partials like a: client, server + b: server, test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay those tests have been added. I think they conform to what you were saying

@herecydev
Copy link
Contributor Author

Give me a little bit, ES lint has flagged all the line endings, so need to fix those up. Will update shortly.

@bebraw
Copy link
Member

bebraw commented Mar 16, 2017

Document this at the README. Good to go after that. Great work. 👍

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #74 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   95.28%   95.45%   +0.16%     
==========================================
  Files           4        4              
  Lines         191      198       +7     
  Branches       62       62              
==========================================
+ Hits          182      189       +7     
  Misses          9        9
Impacted Files Coverage Δ
src/index.js 96.38% <100%> (+0.33%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cd11d...9e21275. Read the comment docs.

@herecydev
Copy link
Contributor Author

I've documented this in the readme, let me know if something else needs adding to it.

@bebraw bebraw merged commit 6bf19b6 into survivejs:master Mar 16, 2017
@bebraw
Copy link
Member

bebraw commented Mar 16, 2017

Published. Amazing work. Thanks. 👍

@herecydev
Copy link
Contributor Author

You're most welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants