Add linter and formatter

.github/workflows/test.yaml

@@ -24,4 +24,4 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: Go-results-${{ matrix.go-version }}
-          path: TestResults-${{ matrix.go-version }}.json
+          path: TestResults-${{ matrix.go-version }}.json

.golangci.yaml

@@ -0,0 +1,84 @@
+linters-settings:
+  gocritic:
+    enabled-tags:
+      - "performance"
+      - "style"
+      - "diagnostic"
+linters:
+  enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - containedctx
+    - contextcheck
+    - cyclop
+    - decorder
+    - dogsled
+    - dupword
+    - durationcheck
+    - errcheck
+    - errname
+    - errorlint
+    - execinquery
+    - exhaustive
+    - exportloopref
+    - forbidigo
+    - ginkgolinter
+    - gocheckcompilerdirectives
+    - gochecknoinits
+    - gocognit
+    - goconst
+    - gocritic
+    - gocyclo
+    - goerr113
+    - gofmt
+    - gofumpt
+    - goheader
+    - goimports
+    - gomoddirectives
+    - gomodguard
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - gosmopolitan
+    - govet
+    - grouper
+    - ifshort
+    - importas
+    - ineffassign
+    - interfacebloat
+    - interfacer
+#    - ireturn # We disable this one since we're returning any's anyway.
+    - loggercheck
+    - maintidx
+    - makezero
+    - mirror
+    - misspell
+    - musttag
+    - nakedret
+    - nestif
+    - nilerr
+    - nilnil
+    - nlreturn
+    - nonamedreturns
+    - nosprintfhostport
+    - paralleltest
+    - prealloc
+    - predeclared
+    - promlinter
+    - reassign
+    - rowserrcheck
+    - sqlclosecheck
+    - staticcheck
+    - tenv
+    - thelper
+    - tparallel
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - usestdlibvars
+    - wastedassign
+    - whitespace
+    - zerologlint

Makefile

@@ -12,4 +12,11 @@ test: fmt ## Run unit tests, alias: t
 
 fmt: ## Format go code
 	@go mod tidy
-	@go fmt ./...
+	@gofumpt -l -w .
+
+tools: ## Install extra tools for development
+	go install mvdan.cc/gofumpt@latest
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
+
+lint: ## Lint the code locally
+	golangci-lint run

map_test.go

@@ -1,9 +1,10 @@
 package tsyncmap
 
 import (
-	"github.com/stretchr/testify/assert"
 	"sync"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 type testKey struct {
@@ -170,6 +171,7 @@ func TestMap_Range_Ranges(t *testing.T) {
 	item.Range(func(k testKey, v testValue) bool {
 		calledWithKey = append(calledWithKey, k)
 		calledWithValue = append(calledWithValue, v)
+
 		return true
 	})
 
@@ -180,10 +182,6 @@ func TestMap_Range_Ranges(t *testing.T) {
 
 // Benchmarks
 
-// Necessary to assign to in benchmarks
-var result any
-var ok bool
-
 func BenchmarkMap_Load(b *testing.B) {
 	object := new(Map[testKey, testValue])
 
@@ -194,7 +192,7 @@ func BenchmarkMap_Load(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.Load(key)
+		object.Load(key)
 	}
 }
 
@@ -208,7 +206,7 @@ func BenchmarkSyncMap_Load(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.Load(key)
+		object.Load(key)
 	}
 }
 
@@ -244,7 +242,7 @@ func BenchmarkMap_LoadOrStore(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.LoadOrStore(key, value)
+		object.LoadOrStore(key, value)
 	}
 }
 
@@ -256,7 +254,7 @@ func BenchmarkSyncMap_LoadOrStore(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.LoadOrStore(key, value)
+		object.LoadOrStore(key, value)
 	}
 }
 
@@ -298,7 +296,7 @@ func BenchmarkMap_LoadAndDelete(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.LoadAndDelete(key)
+		object.LoadAndDelete(key)
 	}
 }
 
@@ -312,7 +310,7 @@ func BenchmarkSyncMap_LoadAndDelete(b *testing.B) {
 
 	b.StartTimer()
 	for i := 0; i < b.N; i++ {
-		result, ok = object.LoadAndDelete(key)
+		object.LoadAndDelete(key)
 	}
 }