Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildSingleRequest has nil CompletedChannel #18

Closed
susamn opened this issue Apr 14, 2020 · 1 comment
Closed

BuildSingleRequest has nil CompletedChannel #18

susamn opened this issue Apr 14, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@susamn
Copy link
Owner

susamn commented Apr 14, 2020

func BuildRequests(context context.Context, task *FutureTask, size int) *Request {

	tasks := make([]*FutureTask, 0, size)
	tasks = append(tasks, task)
	return &Request{Ctx: context, Tasks: tasks, TaskCount: size, CompletedChannel: make(chan bool)}
}

compared to

func BuildSingleRequest(context context.Context, task *FutureTask) *Request {
	tasks := make([]*FutureTask, 1)
	tasks = append(tasks, task)
	return &Request{Ctx: context, Tasks: tasks}
}
@susamn susamn added the bug Something isn't working label Apr 14, 2020
@susamn
Copy link
Owner Author

susamn commented Apr 14, 2020

Fixed

@susamn susamn closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant