Skip to content

Commit

Permalink
Merge pull request #142 from susatthi/chore/140-testing-ja
Browse files Browse the repository at this point in the history
🔧 chore: 言語設定=日本語のテスト対応
  • Loading branch information
susatthi committed May 24, 2022
2 parents 183339e + 0f09802 commit 05c8aff
Show file tree
Hide file tree
Showing 40 changed files with 117 additions and 5 deletions.
23 changes: 18 additions & 5 deletions .github/workflows/flutter_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,32 @@ jobs:
- name: Run Flutter Analyze
run: flutter analyze

# テストを実行
- name: Run Flutter Test
# テストを実行(英語)
- name: Run Flutter Test (locale=en)
run: flutter test --no-test-assets --machine > test-report.log

# テスト結果を GitHub Actions に表示する
- name: Report Test (locale=en)
uses: dorny/test-reporter@v1
if: always()
with:
name: Flutter Test Report (ubuntu-laetst / en)
path: test-report.log
reporter: flutter-json

# テストを実行(日本語)
- name: Run Flutter Test (locale=ja)
run: |
flutter test --no-test-assets --coverage --machine > test-report.log
flutter test --no-test-assets --coverage --machine --dart-define=locale=ja > test-report.log
sudo apt-get install -y lcov
lcov --remove coverage/lcov.info 'lib/utils/assets/*' 'lib/localizations/*' -o coverage/lcov.info
# テスト結果を GitHub Actions に表示する
- name: Report Test
- name: Report Test (locale=ja)
uses: dorny/test-reporter@v1
if: always()
with:
name: Flutter Test Report (ubuntu-laetst)
name: Flutter Test Report (ubuntu-laetst / ja)
path: test-report.log
reporter: flutter-json

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/common/cached_circle_avatar.dart';
import 'package:mocktail/mocktail.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

class MockDefaultCacheManager extends Mock implements DefaultCacheManager {}
Expand All @@ -16,6 +17,7 @@ void main() {
const dummyUrl = 'https://keyber.jp/images/logo_white.png';
late DefaultCacheManager mockCacheManager;
setUp(() {
useEnvironmentLocale();
mockCacheManager = MockDefaultCacheManager();
});

Expand Down
5 changes: 5 additions & 0 deletions test/presentation/components/common/error_view_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ import 'package:github_search/localizations/strings.g.dart';
import 'package:github_search/presentation/components/common/error_view.dart';
import 'package:github_search/repositories/github/exception.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/logger.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);

group('ErrorView', () {
testWidgets('Exceptionを与えてエラーメッセージが表示されるはず', (tester) async {
await _wrapTest(
Expand Down Expand Up @@ -58,5 +62,6 @@ Future<void> _wrapTest(
),
),
);
testLogger.i(expectedMessage);
expect(find.text(expectedMessage), findsOneWidget);
}
2 changes: 2 additions & 0 deletions test/presentation/components/common/hyperlink_text_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/common/hyperlink_text.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('HyperlinkText', () {
testWidgets('正しく表示するはず', (tester) async {
const expectedText = 'リンク';
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/common/icon_label_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/common/icon_label.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('IconLabel', () {
testWidgets('引数無しで意図して動作するはず', (tester) async {
const expectedIcon = Icons.search;
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/common/list_loader_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/common/list_loader.dart';
import 'package:shimmer/shimmer.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('ListLoader', () {
testWidgets('引数無しで意図して動作するはず', (tester) async {
await tester.pumpWidget(
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/common/search_app_bar_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/common/search_app_bar.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('SearchAppBar', () {
testWidgets('デフォルトのAppBarの高さが意図した高さであるはず', (tester) async {
await tester.pumpWidget(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ import 'package:github_search/presentation/components/repo/repo_selected_repo.da
import 'package:github_search/presentation/pages/repo/repo_avatar_preview_page.dart';
import 'package:photo_view/photo_view.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('RepoAvatarPreviewView', () {
testWidgets('PhotoViewが表示されるはず', (tester) async {
await tester.pumpWidget(
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/repo/repo_detail_view_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import 'package:mocktail/mocktail.dart';
// ignore: depend_on_referenced_packages
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

class _MockPage extends StatelessWidget {
Expand All @@ -42,6 +43,7 @@ void main() {
mockUrlLauncherPlatform = MockUrlLauncherPlatform();
UrlLauncherPlatform.instance = mockUrlLauncherPlatform;
mockGoRouter = MockGoRouter();
useEnvironmentLocale();
});

/// ハイパーリンクをタップするテスト
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ import 'package:github_search/presentation/components/repo/repo_full_name_text.d
import 'package:github_search/presentation/components/repo/repo_selected_repo.dart';
import 'package:github_search/repositories/github/http_client.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('RepoFullNameText', () {
testWidgets('正しく表示出来るはず', (tester) async {
await tester.pumpWidget(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/repo/repo_language_label.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('RepoLanguageLabel', () {
testWidgets('正しく表示出来るはず', (tester) async {
const expectedColor = Colors.red;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/repo/repo_list_view_notifier.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
Expand All @@ -22,6 +23,7 @@ void main() {
(previous, next) {},
)
.read();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/repo/repo_list_view_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import 'package:number_display/number_display.dart';
import 'package:visibility_detector/visibility_detector.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

class _MockPage extends StatelessWidget {
Expand All @@ -43,6 +44,7 @@ void main() {
setUp(() async {
tmpDir = await openAppDataBox();
mockGoRouter = MockGoRouter();
useEnvironmentLocale();
});
tearDown(() async {
await closeAppDataBox(tmpDir);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ import 'package:github_search/presentation/components/repo/repo_search_repos_que
import 'package:github_search/repositories/github/http_client.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/logger.dart';
import '../../../test_utils/mocks.dart';

void main() {
late Directory tmpDir;
setUp(() async {
tmpDir = await openAppDataBox();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import 'package:github_search/entities/repo/repo_data.dart';
import 'package:github_search/presentation/components/repo/repo_readme_content.dart';
import 'package:github_search/repositories/github/http_client.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';
import '../../../test_utils/utils.dart';

Expand All @@ -22,6 +23,7 @@ void main() {
TestAssets.readJsonMap('github/get_repo_flutter_flutter.json')!,
),
);
useEnvironmentLocale();
});

group('repoReadmeContentProvider', () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import 'package:mocktail/mocktail.dart';
// ignore: depend_on_referenced_packages
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';
import '../../../test_utils/utils.dart';
import '../common/cached_circle_avatar_test.dart';
Expand Down Expand Up @@ -122,6 +123,7 @@ void main() {
);
mockUrlLauncherPlatform = MockUrlLauncherPlatform();
UrlLauncherPlatform.instance = mockUrlLauncherPlatform;
useEnvironmentLocale();
});

group('RepoReadmeMarkdown', () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import 'package:github_search/presentation/components/repo/repo_search_repos_ord
import 'package:github_search/repositories/repo_repository.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
Expand All @@ -18,6 +19,7 @@ void main() {
setUp(() async {
tmpDir = await openAppDataBox();
container = mockProviderContainer();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/config/env.dart';
import 'package:github_search/presentation/components/repo/repo_search_repos_query.dart';

import '../../../test_utils/locale.dart';

void main() {
late ProviderContainer container;
setUp(() async {
container = ProviderContainer();
useEnvironmentLocale();
});

group('repoSearchReposInitQueryProvider', () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import 'package:github_search/presentation/components/repo/repo_search_repos_sor
import 'package:github_search/repositories/repo_repository.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
Expand All @@ -18,6 +19,7 @@ void main() {
setUp(() async {
tmpDir = await openAppDataBox();
container = mockProviderContainer();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import 'package:github_search/presentation/pages/repo/repo_search_page.dart';
import 'package:go_router/go_router.dart';
import 'package:mocktail/mocktail.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/logger.dart';
import '../../../test_utils/mocks.dart';

Expand All @@ -34,6 +35,7 @@ void main() {
setUp(() {
mockGoRouter = MockGoRouter();
_query = null;
useEnvironmentLocale();
});

group('RepoSearchTextButton', () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/presentation/components/repo/repo_search_repos_query.dart';
import 'package:github_search/presentation/components/repo/repo_search_text_field.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('RepoSearchTextField', () {
testWidgets('検索を実行すると検索文字列を更新するはず', (tester) async {
const expectedQuery = 'foooooo';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import 'package:github_search/presentation/components/repo/repo_selected_repo.da
import 'package:github_search/presentation/pages/repo/repo_view_page.dart';
import 'package:go_router/go_router.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

const _extra = RepoData(
Expand Down Expand Up @@ -65,6 +66,7 @@ void main() {
repoName: 'flutter',
);

setUp(useEnvironmentLocale);
group('repoSelectedRepoProvider', () {
test('最初はStateErrorをthrowするはず', () async {
final container = mockProviderContainer();
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/components/repo/repo_sort_button_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ import 'package:github_search/presentation/components/repo/repo_sort_button.dart
import 'package:github_search/presentation/components/repo/repo_sort_selector_bottom_sheet.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
late Directory tmpDir;
setUp(() async {
tmpDir = await openAppDataBox();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import 'package:github_search/repositories/github/http_client.dart';
import 'package:github_search/utils/extensions.dart';

import '../../../test_utils/hive.dart';
import '../../../test_utils/locale.dart';
import '../../../test_utils/logger.dart';
import '../../../test_utils/mocks.dart';

Expand All @@ -35,6 +36,7 @@ void main() {
late Directory tmpDir;
setUp(() async {
tmpDir = await openAppDataBox();
useEnvironmentLocale();
});

tearDown(() async {
Expand Down
2 changes: 2 additions & 0 deletions test/presentation/pages/common/error_page_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:github_search/localizations/strings.g.dart';
import 'package:github_search/presentation/pages/common/error_page.dart';

import '../../../test_utils/locale.dart';
import '../../../test_utils/mocks.dart';

void main() {
setUp(useEnvironmentLocale);
group('ErrorPage', () {
testWidgets('errorがnullでも問題ないはず', (tester) async {
await tester.pumpWidget(
Expand Down
Loading

0 comments on commit 05c8aff

Please sign in to comment.