-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract artifacts config #480
Extract artifacts config #480
Conversation
006d87c
to
b6a31f8
Compare
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
b6a31f8
to
6af5b97
Compare
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
I worry about adding each override as an individual flag. I think it has the potential to get out of control, and the flags chosen are pretty verbose (though I totally see why you chose them). I think we'd be better served with a single flag, something like That has a few effects:
|
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
eadf712
to
945eb86
Compare
Introduces a new configuration file (
artifacts.yaml
) which will serve to contain all options for the artefacts deployed via EIB. The file will be shipped with each release in both upstream and downstream builds.It is possible to override these values via the newly introduced CLI args.Listing all options:Building an image with custom source values:EDIT: Customising the default artifact sources will be introduced at a later point when we have more context for a better design decision.
Closes #419