Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp: we try to reach the time server even if time_service is set as disabled #102

Closed
theanalyst opened this issue Feb 9, 2017 · 0 comments
Closed

ntp: we try to reach the time server even if time_service is set as disabled #102

theanalyst opened this issue Feb 9, 2017 · 0 comments

Comments

@theanalyst
Copy link
Contributor

theanalyst commented Feb 9, 2017 •
edited 

          ID: time
    Function: salt.state
      Result: False
     Comment: Run failed on minions: tf-salt-minion-1, tf-salt-master, tf-salt-minion-0, tf-salt-minion-3, tf-salt-minion-2
              Failures:
                  tf-salt-minion-1:
                    Name: ntp - Function: pkg.installed - Result: Clean Started: - 10:56:43.069718 Duration: 427.82 ms
                  ----------
                            ID: sync time
                      Function: cmd.run
                          Name: sntp -S -c tf-salt-master
                        Result: False
                       Comment: Command "sntp -S -c tf-salt-master" run
                       Started: 10:56:43.499383
                      Duration: 32.645 ms
                       Changes:   
                                ----------
                                pid:
                                    3843
                                retcode:
                                    1
                                stderr:
                                    tf-salt-master lookup error Name or service not known
                                stdout:
                                    sntp 4.2.8p9@1.3265-o Tue Nov 29 09:15:54 UTC 2016 (1)
                  
                  Summary for tf-salt-minion-1
                  ------------
                  Succeeded: 1 (changed=1)
                  Failed:    1
                  ------------
$ salt "*" pillar.get time_service
tf-salt-minion-0:
    disabled
tf-salt-minion-1:
    disabled
tf-salt-minion-2:
    disabled
tf-salt-minion-3:
    disabled
tf-salt-master:
    disabled
theanalyst added a commit to theanalyst/DeepSea that referenced this issue Feb 9, 2017
@theanalyst
stage3: don't do time sync if not configured
20d7aad 
Currently if time service is set to disabled we still call ceph.time
which tries to sync to the configured ntp server (default master), and
we fail since the time server was disabled, there wouldn't be an ntp
server in master, the other option of actually creating a no op sls file
seems counterintuitive to the validate check and global option of
setting a value to disabled.

Fixes: SUSE#102
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst theanalyst mentioned this issue Feb 9, 2017
Merged
theanalyst added a commit to theanalyst/DeepSea that referenced this issue Feb 10, 2017
@theanalyst
stage3: don't do time sync if not configured
bcdfb08 
Currently if time service is set to disabled we still call ceph.time
which tries to sync to the configured ntp server (default master), and
we fail since the time server was disabled, there wouldn't be an ntp
server in master, the other option of actually creating a no op sls file
seems counterintuitive to the validate check and global option of
setting a value to disabled.

Fixes: SUSE#102
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theanalyst