stage3: don't do time sync if not configured #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if time service is set to disabled we still call ceph.time which tries to sync to the configured ntp server (default master), and we fail since the time server was disabled, there wouldn't be an ntp server in master, the other option of actually creating a no op sls file seems counterintuitive to the validate check and global option of setting a value to disabled. Fixes: SUSE#102 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if time service is set to disabled we still call ceph.time
which tries to sync to the configured ntp server (default master), and
we fail since the time server was disabled, there wouldn't be an ntp
server in master, the other option of actually creating a no op sls file
seems counterintuitive to the validate check and global option of
setting a value to disabled.
Fixes: #102
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com