update gems and rename misnamed "unit" option to "units" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| VCR.turn_on! | ||
| end | ||
|
|
||
| it 'respects overridden options' do |
There was a problem hiding this comment.
I added this spec because I initially thought the overridden unit type wasn't being used. Even though it was being used just not being acknowledged by Google because of the incorrect param (unit instead of units), I kept the spec to provide an assertion that overridden options are indeed used.
|
Nice catch 👍 |
sush
added a commit
that referenced
this pull request
Sep 30, 2015
update gems and rename misnamed "unit" option to "units"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sush this addresses a bug that forces the default
:metricunits. The parameter that Google expects isunits, notunit.I also updated gems while I was at it, and all specs are passing.