fix: Enable network switcher menu for Coinbase Wallet #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brendanww is attempting to deploy a commit to the Team Sushi Team on Vercel. A member of the Team first needs to authorize it. |
|
@jiro-ono would be great to get some 👀 on this |
|
@matthewlilley a polite nudge on checking out this PR |
|
Hey @brendanww, would you mind opening a PR without translations included, and against canary. Ping me and I'll merge ASAP. |
brendanww
force-pushed
the
bw/master-update-wl
branch
from
89b0381
to
dc6ab61
Compare
|
@matthewlilley updated! thank you 🙏 |
|
@brendanww fantastic! lgtm |
|
@brendanww if you could include a PR for canary branch also that would be great, so it doesn't get lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the 3085 network switcher menu for Coinbase Wallet (dapp browser in mobile app, walletlink via mobile device, and walletlink via Coinbase Wallet chromium extension). Also updates walletlink-connector to a version that supports 3085 requests.
Prior PR into canary at
#420
Equivalent PR into uniswap
Uniswap/interface#2753