Threshold labels at extremes not labelled correctly when using custom formatter

[robatwilliams]

Without formatter:

Less than -0.1
More than 0.1

With percentage formatter labelFormat(d3.format('+.1%')):

+NaN% to -12.0%
More than +15.0% to +NaN%

This is due to the replacements made in helpers.js relying on the formatter returning exactly NaN. This would also cause an issue if the default labelDelimiter is changed from "to".

Workaround: copy and adapt the helper.

[susielu]

This has been fixed in v2.25.5 https://github.com/susielu/d3-legend/releases/tag/v2.25.5 let me know if you have any issues with it.

[robatwilliams]

I see that the commit c1bcef8 fixes #78 (more than X vs. X or more), but not this one #77 (NaN% not being replaced).

[susielu]

Ahhh understood. This version should fix this bug as well. d3-svg-legend@2.25.6