fix(react): add OmitKeyof safely and test cases for it #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35369e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 30 30
Lines 505 505
Branches 114 114
=======================================
Hits 431 431
Misses 64 64
Partials 10 10
|
minsoo-web
approved these changes
Mar 24, 2024
Merged
manudeli
pushed a commit
that referenced
this pull request
Mar 27, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@1.26.6 ### Patch Changes - [#816](#816) [`33fe78c`](33fe78c) Thanks [@manudeli](https://github.com/manudeli)! - fix(react): add OmitKeyof safely and test cases for it ## @suspensive/react-query@1.26.6 ### Patch Changes - Updated dependencies \[[`33fe78c`](33fe78c)]: - @suspensive/react@1.26.6 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
manudeli
added a commit
that referenced
this pull request
Mar 31, 2024
Same with #816 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
related with TanStack/query#7139
This change update
OmitKeyofto validate Omitting keys should be keyof Omitted Object TypeAs shown below, the inconvenience of having to manually remove unnecessary fields can be identified early on at the type level with
OmitKeyof.Motivatings
OmitKeyofto Omit object by object's keys strictly TanStack/query#7139 (comment)Expectation
I made test-d to type-test
OmitKeyofOmit, I want to reduce the difficulty of library maintenance for it.OmitKeyofprovide autocomplete by extending keyof TObjectOmitKeyofcheck strictly second type parameter of it by extending keyof TObjectOmitKeyofprevent library contributors make misspell like queryTey or qeuryKeyPR Checklist