Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent Log Levelling #1469

Open
dave-tucker opened this issue May 23, 2024 · 1 comment
Open

Consistent Log Levelling #1469

dave-tucker opened this issue May 23, 2024 · 1 comment
Labels
kind/feature New feature or request tech-debt

Comments

@dave-tucker
Copy link
Collaborator

What would you like to be added?

We should follow some of the guidelines in place here and overhaul our logging:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md

TL;DR

  • Prefer structured logging InfoS instead of InfoF
  • Use log levels 0 (default) -> 5 as documented in the guidelines above
  • Provide some documentation around the use of the -v flag to adjust the log verbosity

Why is this needed?

To make it easier for users and developers of Kepler to understand what's happening!
@dave-tucker dave-tucker added the kind/feature New feature or request label May 23, 2024
@dave-tucker dave-tucker mentioned this issue May 23, 2024
Merged
PalmPalm7 added a commit to PalmPalm7/kepler that referenced this issue Jun 20, 2024
@PalmPalm7
Fixed Consistant Log Levelling
14c8f70 
Made changes to exisisting codebase with structured logs from format logs. [Github issue ref](sustainable-computing-io#1469).

Added logging kepler with klog section on dev/README.md, [see
here](https://github.com/sustainable-computing-io/kepler/blob/main/doc/dev/README.md).
@PalmPalm7 PalmPalm7 mentioned this issue Jun 20, 2024
Closed
PalmPalm7 added a commit to PalmPalm7/kepler that referenced this issue Jun 20, 2024
@PalmPalm7
Fixed Consistant Log Levelling
1400dc5 
Made changes to exisisting codebase with structured logs from format logs. [Github issue ref](sustainable-computing-io#1469).

Added logging kepler with klog section on dev/README.md, [see
here](https://github.com/sustainable-computing-io/kepler/blob/main/doc/dev/README.md).
PalmPalm7 added a commit to PalmPalm7/kepler that referenced this issue Jun 20, 2024
@PalmPalm7
Fixed Consistant Log Levelling
77d4005 
Made changes to exisisting codebase with structured logs from format logs. [Github issue ref](sustainable-computing-io#1469).

Added logging kepler with klog section on dev/README.md, [see
here](https://github.com/sustainable-computing-io/kepler/blob/main/doc/dev/README.md).

Signed-off-by: Andy Xie <anxie@redhat.com>
@PalmPalm7
Copy link

Link to PR: #1490.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dave-tucker @PalmPalm7