-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus: Fixes #197 permission issue for service monitoring #200
prometheus: Fixes #197 permission issue for service monitoring #200
Conversation
…ervice monitoring 1. Move the service monitoring to the namespace of kepler align with deployment 2. Add Role and RoleBinding to allow prometheus monitoring the namespace kepler This has been tested on a local kubernetes cluster. Signed-off-by: Lu Ken <ken.lu@intel.com>
@kenplusplus , one question, did you have once try with https://github.com/sustainable-computing-io/kepler/blob/main/hack/cluster-deploy.sh#L25 ? The thing I am rising up here: in my point of view, if we want user to use a quick solution to deploy promethus operator and kepler ref to [link] (https://prometheus-operator.dev/docs/prologue/quick-start/#deploy-kube-prometheus). or we should make cc: @rootfs , @marceloamaral |
/assign @SamYuan1990 |
If CI is able to query Kepler metrics, that'll be great. I previously tried the following to verify Kepler is working. If the new namespace works with the promtheus change, can we add this check in the CI? export IP=$(kubectl get svc -n monitoring prometheus-k8s -ojsonpath='{.spec.clusterIP}')
curl "http://${IP}:9090/api/v1/query?query=node_energy_stat[200s]" |
ok... @rootfs , I hope a free discussion with items below before adjust CI for testing.
|
for me, @rootfs , @kenplusplus , @marceloamaral please let me know your comments. |
Let's have this fix first, we'll go to the integration CI test case in a followup discussion. @kenplusplus please open up issues based on your use cases. Thanks. |
I will try your CI and try to provide similiar fixing |
This has been tested on a local kubernetes cluster.
Signed-off-by: Lu Ken ken.lu@intel.com