Support hmc client to get energy consumption from IBM System Z #1030
Conversation
pkg/power/platform/source/hmc.go
Outdated
| "k8s.io/klog/v2" | ||
|
|
||
| "github.com/sustainable-computing-io/kepler/pkg/power/components/source" | ||
| "github.com/zhmcclient/golang-zhmcclient/pkg/zhmcclient" |
There was a problem hiding this comment.
do we have any CI case for this?
pkg/power/platform/source/hmc.go
Outdated
| if err != nil { | ||
| klog.V(1).Infof("Error getting energy data: %v", err.Message) | ||
| } | ||
| klog.V(1).Infof("Get energy data successfully") |
There was a problem hiding this comment.
this seems will lead to many logs?
pkg/power/platform/source/hmc.go
Outdated
|
|
||
| func (r *PowerHMC) GetNodeComponentsEnergy() map[int]source.NodeComponentsEnergy { | ||
| pkgEnergy, _ := r.GetLiveEnergyFromLpar() | ||
| pkgEnergy = pkgEnergy * 3 |
There was a problem hiding this comment.
what is *3 for? can you leave a comment?
There was a problem hiding this comment.
It is aimed to align with defaultSamplePeriodSec = 3 used in the kepler. Still try to finalize it and then leave explanation in the comment.
pkg/power/platform/source/hmc.go
Outdated
| func (r *PowerHMC) GetPlatformEnergy() map[string]float64 { | ||
| pkgEnergy, _ := r.GetLiveEnergyFromLpar() | ||
| platformEnergies := make(map[string]float64) | ||
| platformEnergies[hmcSensorID] = float64(pkgEnergy) * 3 |
There was a problem hiding this comment.
is lpar energy at the platform level or pkg level? if it is a platform level energy source, we can probably skip getting pkg energy
There was a problem hiding this comment.
I guess there is no pkg concept in z platform
@jiangphcn can we have a doc describe the relationship between z and x86 concept difference so we know what energy mapping to existing defined variables to give a clear picture?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Peng Hui Jiang <jiangph@cn.ibm.com>
jiangphcn
force-pushed
the
hmc-support
branch
from
1a534ca
to
bb49976
Compare
The purpose of this PR Support is to support external power source: HMC referred in #644.
Starting IBM Z 16, LPAR level power metrics is exposed and available. The golang zhmclient package is enhanced and open-sourced in zhmcclient/golang-zhmcclient@6bb10a7.
Current PR is using such API to provide power consumption calculation for applications running in IBM System Z.