Update manifests and dashboard deploy script #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
manifests-sa-token
branch
3 times, most recently
from
ae99de4
to
3e9cade
Compare
sallyom
changed the title
|
@williamcaban can you take a look? thanks |
|
(the bash script to define grafana dashboard I'm still working on) |
|
@sallyom in this case, could you please update the title with the work in progress status? [WIP] |
sallyom
force-pushed
the
manifests-sa-token
branch
2 times, most recently
from
a6914f8
to
75c6d81
Compare
@marceloamaral (will do) - all seems to be working now, ready for review, thanks! |
williamcaban
reviewed
Sep 9, 2022
williamcaban
reviewed
Sep 9, 2022
|
thank you @williamcaban |
Signed-off-by: Sally O'Malley <somalley@redhat.com>
sallyom
force-pushed
the
manifests-sa-token
branch
from
75c6d81
to
c8df1b7
Compare
williamcaban
approved these changes
Sep 9, 2022
|
thank you @sallyom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally O'Malley somalley@redhat.com
For #126