Add support for golint #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2022
Merged
marceloamaral
changed the title
Signed-off-by: Marcelo Amaral <marcelo.amaral1@ibm.com>
Signed-off-by: Marcelo Amaral <marcelo.amaral1@ibm.com>
rootfs
approved these changes
Sep 13, 2022
|
thanks, would you add this to GH action next? |
SamYuan1990
reviewed
Sep 13, 2022
| @@ -136,6 +136,9 @@ test-verbose: ginkgo-set tidy-vendor | |||
| format: | |||
| gofmt -l -w pkg/ cmd/ | |||
|
|
|||
| golint: | |||
There was a problem hiding this comment.
do we need lint before build?
There was a problem hiding this comment.
for ex
_build_containerized: format golint
There was a problem hiding this comment.
Yes, but since we have many problems now it will be very annoying!
So, after we fix the issues, we can add lint as a requisite for building...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using linters improves the code quality and readability by highlighting problems before they are executed, and it helps with the standardization of the codebase.
This PR enables golint. But, fixing the issues is out of the scope of this PR and will be done in another PR.
Additionally, this is PR is part of the effort for testing the code quality, as describe in the issue #161
Signed-off-by: Marcelo Amaral marcelo.amaral1@ibm.com