Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x: build base image #194

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

huoqifeng
Copy link
Contributor

Build the amd64 and s390x base image, used separate Dockerfile.$arch file as it uses different packages to make it easy to maintain.

These base images will be used by kepler. We don't need a s390x builder as we can use the amd64 builder to build s390x images in future.

Signed-off-by: huoqifeng huoqif@cn.ibm.com

Signed-off-by: huoqifeng <huoqif@cn.ibm.com>
@huoqifeng
Copy link
Contributor Author

@SamYuan1990 @rootfs may you kind review it?

@SamYuan1990
Copy link
Collaborator

@SamYuan1990 @rootfs may you kind review it?

https://github.com/huoqifeng/kepler/actions/workflows/image-base.yml
hi @huoqifeng ,

is CI passed for now?

file: {context}/build/Dockerfile.base.s390x
platforms: linux/s390x
push: true
tags: quay.io/sustainable_computing_io/kepler_base:latest-s390x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you interested in providing a multi-arch image for kepler_base?

@rootfs
Copy link
Contributor

rootfs commented Sep 17, 2022

thank you @huoqifeng

I'd like to have multi-arch images for kepler and kepler_base. If you are interested, please go ahead and create them.

@rootfs rootfs merged commit cdd4dc8 into sustainable-computing-io:main Sep 17, 2022
@huoqifeng
Copy link
Contributor Author

@SamYuan1990 @rootfs may you kind review it?

https://github.com/huoqifeng/kepler/actions/workflows/image-base.yml hi @huoqifeng ,

is CI passed for now?

@SamYuan1990 The target branch is main, maybe it could be checked after merge?

@huoqifeng
Copy link
Contributor Author

thank you @huoqifeng

I'd like to have multi-arch images for kepler and kepler_base. If you are interested, please go ahead and create them.

Sure, I can add it, it might be different as usual as buildx because we're using different Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants