Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-arch: build kepler multi-arch image #203

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

huoqifeng
Copy link
Contributor

@huoqifeng huoqifeng commented Sep 18, 2022

Use amd64 builder to build cross-platform kepler image. It depends on multi-arch kepler_base image.

Signed-off-by: huoqifeng huoqif@cn.ibm.com

Signed-off-by: huoqifeng <huoqif@cn.ibm.com>
@huoqifeng
Copy link
Contributor Author

huoqifeng commented Sep 18, 2022

Depends on #202 and still WIP.

@huoqifeng
Copy link
Contributor Author

huoqifeng commented Sep 27, 2022

@rootfs based on the flow here https://github.com/sustainable-computing-io/kepler/blob/main/.github/workflows/image-base.yml#L6, may you please create a branch base so that we can get a multi-arch kepler_base image built and pushed, so that this PR can move ahead. maybe, may you please grant my access to branch base also, I can fix any problems found quickly...

@rootfs
Copy link
Contributor

rootfs commented Sep 27, 2022

@huoqifeng here you go
image

@rootfs
Copy link
Contributor

rootfs commented Jan 4, 2023

@huoqifeng are you still working on it? this will be very helpful once we have arm64 support, thanks

@huoqifeng
Copy link
Contributor Author

@rootfs Sorry, I was busy on other projects, hopefully, I can check it this weekend.

@rootfs
Copy link
Contributor

rootfs commented Jan 5, 2023

@huoqifeng thanks! You don't have to get everything in this PR. If you can make your work in a good shape, I'll pick up where you have left and ping you for review later.

@huoqifeng
Copy link
Contributor Author

@rootfs I think we need make sure https://github.com/sustainable-computing-io/kepler/blob/base/.github/workflows/image-base.yml work well as it will generate and push the base image, which is the base for multi-arch kepler images. I remembered I don't have permission to rebase and push the branch base. May you help grant my write access to this base branch?

@huoqifeng
Copy link
Contributor Author

Lack of the permission to rebase branch base to main. anyone can help on that?

@SamYuan1990 SamYuan1990 changed the base branch from main to base January 7, 2023 09:30
@SamYuan1990
Copy link
Collaborator

Lack of the permission to rebase branch base to main. anyone can help on that?

changed the base branch from main to base.

@rootfs
Copy link
Contributor

rootfs commented Jan 7, 2023

the integration test log is missing, do you happen to know what failed in the test? @huoqifeng

@rootfs rootfs changed the title [WIP] multi-arch: build kepler multi-arch image multi-arch: build kepler multi-arch image Jan 7, 2023
@huoqifeng
Copy link
Contributor Author

I think we need make base branch get built successfully first, unfortunately I don't have permission to rebase the base branch.

@rootfs
Copy link
Contributor

rootfs commented Jan 9, 2023

@huoqifeng let's pick up the change and see if the build works in the base branch.

@rootfs rootfs merged commit f8c72bf into sustainable-computing-io:base Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants