impl for integration test #292
Conversation
|
redo for #275 |
Signed-off-by: Sam Yuan <yy19902439@126.com>
SamYuan1990
force-pushed
the
integrationTest3rdround
branch
from
43887ac
to
20718a3
Compare
|
a part of #162 |
Which models? Power models? |
| if !ok { | ||
| address = "localhost:8888" | ||
| cmd := exec.Command(keplerBin) | ||
| keplerSession, err = gexec.Start(cmd, nil, nil) |
There was a problem hiding this comment.
Will the test start Kepler alone or with the other components, like the Model Server?
If it is only Kepler, what is the integration test part?
I am not saying that this test here is not important, but it might not be integration test as the title suggest...
There was a problem hiding this comment.
In the case it is not integration test, this is definitely a functional test that we need to have
|
As I think this PR relates to kepler-model-server and kepler-estimator integration test and I don't want to duplicate the work here, please excuse me to put some of my thought here. First of all, here is the integration test flow for kepler-estimator connecting to kepler-model-server with kind cluster: https://github.com/sustainable-computing-io/kepler-estimator/blob/main/.github/workflows/integration_test.yaml. I think we can do a similar thing with kepler integration test but, for simplicity, I think we should let kepler defines its configurations from configmap resource rather than changing the main deployment environment or command argument (please check PR #284). Then, we can easily configure ModelConfig implemented by this PR #225, in the same way as I did with configmap of kepler-estimator to whether to use kepler-model-server, kepler-estimator or not. We can create test cases including
|
| @@ -86,6 +86,8 @@ github.com/onsi/ginkgo/types | |||
| ## explicit; go 1.18 | |||
| github.com/onsi/gomega | |||
| github.com/onsi/gomega/format | |||
| github.com/onsi/gomega/gbytes | |||
There was a problem hiding this comment.
why not change in go.mod and go.sum?
|
@SamYuan1990 I just have a question on go mod. @sunya-ch sounds good! After this PR, can you create an issue/request? @marceloamaral @sunya-ch anything else is needed for this PR? It'll be great to have an initial integration test in place and add more in the future. |
Sure. I can push the PR for the deployment CI test later after all components is clearly integrated. |
Details for this PR
e2e folder with end to end testing, will run with two models, base on environment kepler_address.
build kepler during test process and run it targets on local.
run test case targets on cluster after cluster port forwarding.
Signed-off-by: Sam Yuan yy19902439@126.com